[Bug 1075717] Re: mounted-dev must not re-create consoles in a container

[Stéphane Graber]

This needs fixing in precise too. I just ran into that very problem with
current upstream LXC and a precise privileged container.

I'll upload a straight cherry-pick of the mounted-dev.conf job as we
have it nowadays (I confirmed that fixes it here).

** Also affects: lxc (Ubuntu Precise)
   Importance: Undecided
       Status: New

** Also affects: mountall (Ubuntu Precise)
   Importance: Undecided
       Status: New

** Changed in: lxc (Ubuntu Precise)
       Status: New => Invalid

** Changed in: mountall (Ubuntu Precise)
       Status: New => Triaged

** Changed in: mountall (Ubuntu Precise)
     Assignee: (unassigned) => Stéphane Graber (stgraber)

** Changed in: mountall (Ubuntu Precise)
   Importance: Undecided => High

** Description changed:

  mounted-dev.conf always does MAKEDEV console.  MAKEDEV doesn't just make
  the devices, it first removes them.
  
  When a container starts, it sets up /dev/console and /dev/lxc[1-4] as
  bind mounts of ptys on the host, for use as lxc consoles.  If mounted-
  dev deletes and recreates those, then none of the lxc consoles work.
  
  A simple patch which stops it from breaking lxc consoles is at lp
  :~serge-hallyn/ubuntu/quantal/mountall/mountall-lxc .  However looking
  back at it, I think it would be ok to do a further check for whether
  /dev/console exists.  If it does not exist, then MAKEDEV console anyway.
  This isn't necessary, just a thought.
+ 
+ 
+ == SRU ==
+ === Rationale ===
+ This bug was fixed in trusty but still affects precise LXC containers that are brought up with /dev mounted as something other than a devtmpfs (which is the case with LXC 1.1).
+ 
+ === Test case ===
+     - Install LXC 1.1 (from ppa:ubuntu-lxc/daily or in a few days, from vivid)
+     - sudo lxc-create -t download -n precise -- -d ubuntu -r precise -a amd64
+     - sudo lxc-start -n precise -F
+ 
+ That will hang at a blank screen even though the container is
+ functional.
+ 
+     - sudo lxc-attach -n precise -- apt-get dist-upgrade -y
+     - sudo lxc-attach -n precise -- reboot
+ 
+ And at that point, getty should show up fine in the lxc-start shell.
+ 
+ === Regression potential ===
+ Not expecting any, the change is straightforward and has been in Ubuntu since raring.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to mountall in Ubuntu.
https://bugs.launchpad.net/bugs/1075717

Title:
  mounted-dev must not re-create consoles in a container

Status in lxc package in Ubuntu:
  Fix Released
Status in mountall package in Ubuntu:
  Fix Released
Status in lxc source package in Precise:
  Invalid
Status in mountall source package in Precise:
  Triaged

Bug description:
  mounted-dev.conf always does MAKEDEV console.  MAKEDEV doesn't just
  make the devices, it first removes them.

  When a container starts, it sets up /dev/console and /dev/lxc[1-4] as
  bind mounts of ptys on the host, for use as lxc consoles.  If mounted-
  dev deletes and recreates those, then none of the lxc consoles work.

  A simple patch which stops it from breaking lxc consoles is at lp
  :~serge-hallyn/ubuntu/quantal/mountall/mountall-lxc .  However looking
  back at it, I think it would be ok to do a further check for whether
  /dev/console exists.  If it does not exist, then MAKEDEV console
  anyway.  This isn't necessary, just a thought.

  
  == SRU ==
  === Rationale ===
  This bug was fixed in trusty but still affects precise LXC containers that are brought up with /dev mounted as something other than a devtmpfs (which is the case with LXC 1.1).

  === Test case ===
      - Install LXC 1.1 (from ppa:ubuntu-lxc/daily or in a few days, from vivid)
      - sudo lxc-create -t download -n precise -- -d ubuntu -r precise -a amd64
      - sudo lxc-start -n precise -F

  That will hang at a blank screen even though the container is
  functional.

      - sudo lxc-attach -n precise -- apt-get dist-upgrade -y
      - sudo lxc-attach -n precise -- reboot

  And at that point, getty should show up fine in the lxc-start shell.

  === Regression potential ===
  Not expecting any, the change is straightforward and has been in Ubuntu since raring.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1075717/+subscriptions