[Bug 1332164] Re: Battery powered keyboard gives invalid laptop detection

[David Piggott]

I have the same issue but on a laptop (XPS 13). So for me it doesn't
cause the problem of making the system be detected as a laptop (it
really is one), but it does result in the system tray's power icon
seemingly undeterministically changing  between reporting the actual
laptop battery's state, and the keyboard battery's state as the overall
system power state. I would expect/prefer it to only report the real
laptop battery state.

I'm about to attach three screenshots that show the power state dialog's
view of my keyboard (which incorrectly shows as an additional laptop
battery), my mouse (which correctly shows as a mouse, with power state),
and the actual laptop battery.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to laptop-detect in Ubuntu.
https://bugs.launchpad.net/bugs/1332164

Title:
  Battery powered keyboard gives invalid laptop detection

Status in laptop-detect package in Ubuntu:
  Confirmed

Bug description:
  laptop-mode will assume the system is a laptop if any battery is
  found.

  I am running a desktop PC with a bluetooth battery powered Logitech
  K810 keyboard.

  $ cat /sys/class/bluetooth/hci0:64/address 
  00:1f:20:91:df:35
  $ ls /sys/class/power_supply 
  hid-00:1f:20:91:df:35-battery
  $ cat /sys/class/power_supply/hid-00:1f:20:91:df:35-battery/type
  Battery
  $ cat /sys/class/power_supply/hid-00:1f:20:91:df:35-battery/scope
  Device

  The following laptop-detect code will assume the keyboard battery is
  an ACPI battery:

  # check for any ACPI batteries
  /sbin/modprobe battery 2> /dev/null || true
  if [ -d /sys/class/power_supply ]; then
      for i in "`ls /sys/class/power_supply/*/ 2>/dev/null | grep -v hid`"; do
              if grep -q Battery $i/type 2>/dev/null; then
              $PRINTIT "We're a laptop (ACPI batteries found)" >&2
              exit 0
  	fi
      done
  fi

  Suggestion: filtering out /sys/class/power_supply/hid* before checking
  battery type, or filter out scope = Device

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/laptop-detect/+bug/1332164/+subscriptions