[Bug 1422290] Re: Default charsets handling for Windows archives in CJKV+th locale

[Yuan Chao]

Dear @Nobuto,

I appreciate the patch work very much, but it simply doesn't fit my use case. Quite frequently, I get
zip files with CJK file names from zh_CN and ja_JP. (my environment is either zh_TW or en_US, the
later which is for office desktop PC) Changing LC_CTYPE to something other than UTF8 is definitely
*no good* here. This would generate more "monjikai" file names. Changing LC_MESSAGE is not
necessary since I can read either. Adding support in the GUI front-end is really needed here.

My use case may be not close to general end users. But I know many experienced users used to adopt
en_US locale to be able to use the type-n-search for launching applications. (surely this is another issue)

Another thing I met before is using CJKV in the archiving password. Not sure if this is (still) a problem?
(unrar and unzip)

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to unzip in Ubuntu.
https://bugs.launchpad.net/bugs/1422290

Title:
  Default charsets handling for Windows archives in CJKV+th locale

Status in unzip package in Ubuntu:
  Triaged
Status in unzip package in Debian:
  Confirmed

Bug description:
  With the current unzip package in Ubuntu, we need to specify charset
  explicitly to extract zip files sent from localized Windows systems.

  For example zip files sent from Japanese localized Windows,
  $ zipinfo -O CP932 sent-from-localized-windows.zip
  $ unzip -O CP932 sent-from-localized-windows.zip

  This method won't work for GUI application like file-roller, users do
  not have way to specify charset from GUI.

  Attached branch adds default charsets handling for Windows archives in
  CJKV+th locale, inspired by Ubuntu Kylin way.

  As a result of bug #580961, two options have been added as Ubuntu patch.
  > -O CHARSET specify a character encoding for DOS, Windows and OS/2 archives
  > -I CHARSET specify a character encoding for UNIX and other archives

  Then Ubuntu Kylin added default encoding as environment variables for their distribution.
  http://bazaar.launchpad.net/~ubuntukylin-members/ubuntukylin-default-settings/trunk/revision/171

  Now as Ubuntu, we can go further by a better way:
   - per user settings by their locales instead of global settings
   - don't interfere in other locales by locale guard

  I only add "-O", so no behavior change for zip files created on Ubuntu
  or other Linux/UNIX systems. This branch just handles zip file created
  on localized Windows system seamlessly.

  charsets list is taken from:
  https://msdn.microsoft.com/en-us/goglobal/bb964654
  and
  msdos/msdos.c in unzip package:
     1682 case 932: /* Japanese */
     1683 case 949: /* Korean */
     1684 case 936: /* Chinese, simple */
     1685 case 950: /* Chinese, traditional */
     1686 case 874: /* Thai */
     1687 case 1258: /* Vietnamese */

  (Copied from @nobuto's branch description.)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/unzip/+bug/1422290/+subscriptions