[Bug 1330312] [NEW] git-gui cannot handle Non-ASCII character in gui.recentrepo

[LittleBigBrain]

Public bug reported:

git gui works fine when there is no non-ASCII character in recentrepo entries.
Git gui can open the path with non-ASCII characters without any problem.
However if the gui.recentrepo contain non-ASCII characters, it will throw out an error.

The user.name can contain non-ASCII UTF8 characters .This works fine:

    git config --list
    user.name=NewUSer∞ π ∅
    user.email=NewUSer at example.com
    gui.recentrepo=/home/user/Documents/test.git

git gui can start without error.

However, if we put the non-ASCII characters into the gui.recentrepo:
    git config --global --add gui.recentrepo /home/user/Documents/∞_π_∅

    git config --list
    user.name=NewUSer∞ π ∅
    user.email=NewUSer at example.com
    gui.recentrepo=/home/user/Documents/test.git
    gui.recentrepo=/home/user/Documents/∞_π_∅

git gui will fail:

    > git gui
    Error in startup script: child process exited abnormally
        while executing
    "exec /usr/lib/git-core/git-config --global --unset gui.recentrepo {^/home/user/Documents/â_Ï_â$}"
        ("eval" body line 1)
        invoked from within
    "eval exec $opt $cmdp $args"
        (procedure "git" line 23)
        invoked from within
    "git config --global --unset gui.recentrepo "^$p\$""
        (procedure "_unset_recentrepo" line 3)
        invoked from within
    "_unset_recentrepo $p"
        (procedure "_get_recentrepos" line 7)
        invoked from within
    "_get_recentrepos"
        (procedure "choose_repository::pick" line 86)
        invoked from within
    "choose_repository::pick"
        invoked from within
    "if {[catch {
                    set _gitdir $env(GIT_DIR)
                    set _prefix {}
                    }]
            && [catch {
                    # beware that from the .git dir this sets _gitdir to .
                    # and _prefix t..."
        (file "/usr/lib/git-core/git-gui" line 1250)

** Affects: git (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to git in Ubuntu.
https://bugs.launchpad.net/bugs/1330312

Title:
  git-gui cannot handle Non-ASCII character in gui.recentrepo

Status in “git” package in Ubuntu:
  New

Bug description:
  git gui works fine when there is no non-ASCII character in recentrepo entries.
  Git gui can open the path with non-ASCII characters without any problem.
  However if the gui.recentrepo contain non-ASCII characters, it will throw out an error.

  The user.name can contain non-ASCII UTF8 characters .This works fine:

      git config --list
      user.name=NewUSer∞ π ∅
      user.email=NewUSer at example.com
      gui.recentrepo=/home/user/Documents/test.git

  git gui can start without error.

  However, if we put the non-ASCII characters into the gui.recentrepo:
      git config --global --add gui.recentrepo /home/user/Documents/∞_π_∅

      git config --list
      user.name=NewUSer∞ π ∅
      user.email=NewUSer at example.com
      gui.recentrepo=/home/user/Documents/test.git
      gui.recentrepo=/home/user/Documents/∞_π_∅

  git gui will fail:

      > git gui
      Error in startup script: child process exited abnormally
          while executing
      "exec /usr/lib/git-core/git-config --global --unset gui.recentrepo {^/home/user/Documents/â_Ï_â$}"
          ("eval" body line 1)
          invoked from within
      "eval exec $opt $cmdp $args"
          (procedure "git" line 23)
          invoked from within
      "git config --global --unset gui.recentrepo "^$p\$""
          (procedure "_unset_recentrepo" line 3)
          invoked from within
      "_unset_recentrepo $p"
          (procedure "_get_recentrepos" line 7)
          invoked from within
      "_get_recentrepos"
          (procedure "choose_repository::pick" line 86)
          invoked from within
      "choose_repository::pick"
          invoked from within
      "if {[catch {
                      set _gitdir $env(GIT_DIR)
                      set _prefix {}
                      }]
              && [catch {
                      # beware that from the .git dir this sets _gitdir to .
                      # and _prefix t..."
          (file "/usr/lib/git-core/git-gui" line 1250)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/git/+bug/1330312/+subscriptions