[Bug 1249732] Re: bzr verify-signature fails when acceptable_keys is defined

[Launchpad Bug Tracker]

This bug was fixed in the package bzr - 2.6.0+bzr6593-1ubuntu1.1

---------------
bzr (2.6.0+bzr6593-1ubuntu1.1) trusty; urgency=medium

  * Fix verify-signature command crashing:
    - on non ascii characters (LP: #1123460)
    - when acceptable_keys configuration option is specified (LP: #1249732)
 -- Dimitri John Ledkov <xnox at ubuntu.com>   Fri, 09 May 2014 03:48:24 +0100

** Changed in: bzr (Ubuntu Trusty)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to bzr in Ubuntu.
https://bugs.launchpad.net/bugs/1249732

Title:
  bzr verify-signature fails when acceptable_keys is defined

Status in Bazaar Version Control System:
  Fix Released
Status in “bzr” package in Ubuntu:
  Fix Released
Status in “bzr” source package in Saucy:
  Won't Fix
Status in “bzr” source package in Trusty:
  Fix Released

Bug description:
  Please keep this description header, needed for Ubuntu SRU to Trusty.
  Please see https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template

   Impact:

   Bzr crashes when verifying non-ascii characters in signatures, in
   verbose mode.

   Testcase:

   bzr branch lp:~xnox/+junk/test-signatures
   cd test-signatures
   gpg --import key.asc
   bzr config "acceptable_keys=*@example.net"
   bzr verify-signatures

  
  Original Report:
  Hi,

  I updated my ~/.bazaar/bazaar.conf file adding the following:

  acceptable_keys = *@canonical.com

  It seems that the option causes 'bzr verify-signatures' to now fail as
  follows:

  $ bzr verify-signatures -v
  bzr: ERROR: exceptions.AttributeError: 'list' object has no attribute 'split'

  Traceback (most recent call last):
    File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 930, in exception_to_return_code
      return the_callable(*args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 1121, in run_bzr
      ret = run(*run_argv)
    File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 673, in run_argv_aliases
      return self.run(**all_cmd_args)
    File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 697, in run
      return self._operation.run_simple(*args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/bzrlib/cleanup.py", line 136, in run_simple
      self.cleanups, self.func, *args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/bzrlib/cleanup.py", line 166, in _do_with_cleanups
      result = func(*args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/bzrlib/commit_signature_commands.py", line 127, in run
      gpg_strategy.set_acceptable_keys(acceptable_keys)
    File "/usr/lib/python2.7/dist-packages/bzrlib/gpg.py", line 354, in set_acceptable_keys
      patterns = key_patterns.split(",")
  AttributeError: 'list' object has no attribute 'split'

  bzr 2.6.0 on python 2.7.5 (Linux-3.11.0-13-generic-x86_64-with-
      Ubuntu-13.10-saucy)
  arguments: ['/usr/bin/bzr', 'verify-signatures', '-v']
  plugins: bash_completion[2.6.0], bzrtools[2.5.0], changelog_merge[2.6.0],
      grep[2.6.0], launchpad[2.6.0], netrc_credential_store[2.6.0],
      news_merge[2.6.0], po_merge[2.6.0], stats[0.2.0dev], weave_fmt[2.6.0]
  encoding: 'utf-8', fsenc: 'UTF-8', lang: 'en_AU.UTF-8'

  *** Bazaar has encountered an internal error.  This probably indicates a
      bug in Bazaar.  You can help us fix it by filing a bug report at
          https://bugs.launchpad.net/bzr/+filebug
      including this traceback and a description of the problem.

  $ apt-cache policy bzr
  bzr:
    Installed: 2.6.0-3ubuntu1
    Candidate: 2.6.0-3ubuntu1
    Version table:
   *** 2.6.0-3ubuntu1 0
          500 http://archive.ubuntu.com/ubuntu/ saucy/main amd64 Packages
          100 /var/lib/dpkg/status

  Regards,

  Haw

  ProblemType: Bug
  DistroRelease: Ubuntu 13.10
  Package: bzr 2.6.0-3ubuntu1
  ProcVersionSignature: Ubuntu 3.11.0-13.20-generic 3.11.6
  Uname: Linux 3.11.0-13-generic x86_64
  ApportVersion: 2.12.5-0ubuntu2.1
  Architecture: amd64
  Date: Sun Nov 10 17:53:03 2013
  MarkForUpload: True
  PackageArchitecture: all
  SourcePackage: bzr
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/bzr/+bug/1249732/+subscriptions