[Bug 1269886] Re: autopkgtest fails in trusty: TestSmartTCPServer.test_graceful_shutdown_waits_for_clients_to_stop

[Vincent Ladeuil]

Bug #888629 and bug #888631 are two known transient failures caused by a
race introduced in revno 6170.

That race condition has been diagnosed (unfortunately incompletely :-( )
long ago as being caused by running a TCP server  and TCP client in the
same process.


The strategy would be to run the test servers in their own process to avoid the race entirely. This is a significant work, unlikely to happen soon.

I'll try to reproduce it locally when time permits, who knows, we may be
lucky and some change in python has made the race more obvious...

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to bzr in Ubuntu.
https://bugs.launchpad.net/bugs/1269886

Title:
  autopkgtest fails in trusty:
  TestSmartTCPServer.test_graceful_shutdown_waits_for_clients_to_stop

Status in “bzr” package in Ubuntu:
  Confirmed

Bug description:
  Since January 11, bzr now consistently [1] fails this test:

  FAIL: bzrlib.tests.test_smart_transport.TestSmartTCPServer.test_graceful_shutdown_waits_for_clients_to_stop
  ----------------------------------------------------------------------
  Traceback (most recent call last):
  _StringException: log: {{{
  INFO  Requested to stop gracefully
  890.268  Stopping SmartServerSocketStreamMedium(client=('127.0.0.1', 58228))
      INFO  Waiting for 1 client(s) to finish
      INFO  Requested to stop gracefully
  }}}

  Traceback (most recent call last):
    File "/usr/lib/python2.7/dist-packages/bzrlib/tests/test_smart_transport.py", line 1458, in test_graceful_shutdown_waits_for_clients_to_stop
      self.assertFalse(server._fully_stopped.isSet())
    File "/usr/lib/python2.7/unittest/case.py", line 418, in assertFalse
      raise self.failureException(msg)
  AssertionError: True is not false

  This is consistent with the update of python 2.7 to some new upstream
  updates [3], so it's likely that this introduced some behavioural
  change.

  
  [1] https://jenkins.qa.ubuntu.com/job/trusty-adt-bzr/
  [2] https://jenkins.qa.ubuntu.com/job/trusty-adt-bzr/13/ARCH=i386,label=adt/console
  [3] https://launchpad.net/ubuntu/+source/python2.7/2.7.6-5

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/1269886/+subscriptions