[Bug 1210503] Re: "allow-stderr" tests that produce stderr output always pass

[Launchpad Bug Tracker]

This bug was fixed in the package autopkgtest - 2.3.3

---------------
autopkgtest (2.3.3) unstable; urgency=low


  * runner/adt-run: Drop "errors" keyword from decode() call to fix
    compatibility with earlier Python versions. Thanks Christoph Berg.
  * adt-run: Fail tests if they exit with nonzero if "allow-stderr"
    restriction is set. Thanks Robie Basak! (LP: #1210503)

 -- Martin Pitt <mpitt at debian.org>  Mon, 09 Sep 2013 15:49:52 -0400

** Changed in: autopkgtest (Ubuntu)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to autopkgtest in Ubuntu.
https://bugs.launchpad.net/bugs/1210503

Title:
  "allow-stderr" tests that produce stderr output always pass

Status in “autopkgtest” package in Ubuntu:
  Fix Released

Bug description:
  Steps to reproduce:

  1. Write a test that produces stderr output, but then returns exit status 1.
  2. Run adt-run against the test.

  Expected results: test failure.
  Actual results: test pass.

  This seems to be due to the following code ("rc" contains the exit
  status of the test run).

          if stab.st_size != 0:
                  l = open(se_read).readline()
                  l = l.rstrip('\n \t\r')
                  if 'allow-stderr' not in t.restriction_names:
                      if len(l) > 35: l = l[:35] + '...'
                      t.reportfail('status: %d, stderr: %s' % (rc, l))
                  else:
                      t.report('PASS')
                  t._debug(' - - - - - - - - - - stderr - - - - - - - - - -')
                  debug_file(se_read)
          elif rc != 0:
                  t.reportfail('non-zero exit status %d' % rc)
          else:
                  t.report('PASS')

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/autopkgtest/+bug/1210503/+subscriptions