[Bug 1212208] Re: quilt patches are not applied during --unbuilt-tree build

[Robie Basak]

My expectation was that if adt-run first 1) builds and 2) tests, then
the "builds" step would be the same as the build step performed by other
tools. Since other tools automatically apply all quilt patches, thus I
expected adt-run to do so as well.

Ian> What if you want to use adt-run to see whether a particular patch
is still needed, for example?

Then I would expect to do the same as if I wanted to build a test
package to see if a particular patch is still needed. Since I expect the
usual build tools to apply all patches for me, I would pop the patch but
also comment it out in the series file. Or alternatively, use an option
to not apply all quilt patches by default. But I'd expect that to be the
exception and not the norm.

Martin> Of course we should only do that for 3.0 (quilt) sources, not
for other formats.

Right. And it's the inconsistency that confused me.

But whichever way, I just thought I'd flag what I considered to be
behaviour inconsistent with the way the packaging tools work. What you
decide to do about it is not up to me :)

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to autopkgtest in Ubuntu.
https://bugs.launchpad.net/bugs/1212208

Title:
  quilt patches are not applied during --unbuilt-tree build

Status in “autopkgtest” package in Ubuntu:
  Triaged

Bug description:
  Steps to reproduce:

  1. Pick a "3.0 (quilt) package" and unpack the source directory.
  2. Run "quilt pop -a"
  3. Run adt-run --unbuilt-tree against this source directory.

  Expected results: adt-run builds the source correctly, including an initial "quilt push -a" in its build area.
  Actual results: the package is built and tested without patches being applied.

  adt-run(1) says:

         --unbuilt-tree directory
                Specifies that tests from the unbuilt source tree directory should be run.  This is  very  similar  to
                specifing  --source  except that a directory tree (which should be pristine) is supplied, instead of a
                source package.

  It doesn't specify that patches will be applied, but "which should be
  pristine" is a bit ambiguous here. I'm not sure that it ever makes
  sense to build a package without quilt patches applied, and it is
  quite confusing and hard to track down when this happens. Please
  detect "3.0 (quilt)" and apply all patches by default.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/autopkgtest/+bug/1212208/+subscriptions