[Bug 1234691] Re: apt-utils: Ignore APT::FTPArchive::Packages::SHA512 option

[Colin Watson]

** Description changed:

  SRU justification:
  
- [Impact] Configuration of whether to generate SHA512 checksums for Packages files in apt-ftparchive doesn't work properly.
+ [Impact] Configuration of whether to generate SHA512 checksums for Packages files in apt-ftparchive doesn't work properly; setting APT::FTPArchive::Packages::SHA512 to false in fact disables SHA256 checksums.
  [Test Case] Generate Packages files with APT::FTPArchive::Packages::SHA512 set to each of true and false, and make sure both work.
  [Regression Potential] Confined to apt-ftparchive.  Probably best to diff Packages/Sources files before and after.
  
  Original report follows:
  
  Imported from Debian bug http://bugs.debian.org/680252:
  
  Package: apt-utils
  Version: 0.9.7.1
  Severity: normal
  
  Dear Maintainer,
  
  I see a typo in ftparchive/writer.cc line 321 :
  
     DoSHA1 = _config->FindB("APT::FTPArchive::Packages::SHA1",DoSHA1);
     DoSHA256 = _config->FindB("APT::FTPArchive::Packages::SHA256",DoSHA256);
     DoSHA256 = _config->FindB("APT::FTPArchive::Packages::SHA512",true);
  
  Second Do should be DoSHA512 and should use DoSHA512 option defined line
  68
  
     DoMD5 = _config->FindB("APT::FTPArchive::MD5",true);
     DoSHA1 = _config->FindB("APT::FTPArchive::SHA1",true);
     DoSHA256 = _config->FindB("APT::FTPArchive::SHA256",true);
     DoSHA512 = _config->FindB("APT::FTPArchive::SHA512",true);
  
  Christian
  
  -- System Information:
  Debian Release: wheezy/sid
    APT prefers unstable
    APT policy: (500, 'unstable')
  Architecture: i386 (i686)
  
  Kernel: Linux 3.4.4 (SMP w/8 CPU cores; PREEMPT)
  Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
  Shell: /bin/sh linked to /bin/dash
  
  Versions of packages apt-utils depends on:
  ii  libapt-inst1.5  0.9.7.1
  ii  libapt-pkg4.12  0.9.7.1
  ii  libc6           2.13-34
  ii  libdb5.1        5.1.29-5
  ii  libgcc1         1:4.7.1-3
  ii  libstdc++6      4.7.1-3
  
  apt-utils recommends no packages.
  
  Versions of packages apt-utils suggests:
  ii  xz-utils  5.1.1alpha+20120614-1
  
  -- no debconf information

** Tags removed: verification-needed
** Tags added: verification-done

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apt in Ubuntu.
https://bugs.launchpad.net/bugs/1234691

Title:
  apt-utils: Ignore APT::FTPArchive::Packages::SHA512 option

Status in “apt” package in Ubuntu:
  Fix Released
Status in “apt” source package in Precise:
  Fix Committed
Status in “apt” package in Debian:
  Fix Released

Bug description:
  SRU justification:

  [Impact] Configuration of whether to generate SHA512 checksums for Packages files in apt-ftparchive doesn't work properly; setting APT::FTPArchive::Packages::SHA512 to false in fact disables SHA256 checksums.
  [Test Case] Generate Packages files with APT::FTPArchive::Packages::SHA512 set to each of true and false, and make sure both work.
  [Regression Potential] Confined to apt-ftparchive.  Probably best to diff Packages/Sources files before and after.

  Original report follows:

  Imported from Debian bug http://bugs.debian.org/680252:

  Package: apt-utils
  Version: 0.9.7.1
  Severity: normal

  Dear Maintainer,

  I see a typo in ftparchive/writer.cc line 321 :

     DoSHA1 = _config->FindB("APT::FTPArchive::Packages::SHA1",DoSHA1);
     DoSHA256 = _config->FindB("APT::FTPArchive::Packages::SHA256",DoSHA256);
     DoSHA256 = _config->FindB("APT::FTPArchive::Packages::SHA512",true);

  Second Do should be DoSHA512 and should use DoSHA512 option defined
  line 68

     DoMD5 = _config->FindB("APT::FTPArchive::MD5",true);
     DoSHA1 = _config->FindB("APT::FTPArchive::SHA1",true);
     DoSHA256 = _config->FindB("APT::FTPArchive::SHA256",true);
     DoSHA512 = _config->FindB("APT::FTPArchive::SHA512",true);

  Christian

  -- System Information:
  Debian Release: wheezy/sid
    APT prefers unstable
    APT policy: (500, 'unstable')
  Architecture: i386 (i686)

  Kernel: Linux 3.4.4 (SMP w/8 CPU cores; PREEMPT)
  Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
  Shell: /bin/sh linked to /bin/dash

  Versions of packages apt-utils depends on:
  ii  libapt-inst1.5  0.9.7.1
  ii  libapt-pkg4.12  0.9.7.1
  ii  libc6           2.13-34
  ii  libdb5.1        5.1.29-5
  ii  libgcc1         1:4.7.1-3
  ii  libstdc++6      4.7.1-3

  apt-utils recommends no packages.

  Versions of packages apt-utils suggests:
  ii  xz-utils  5.1.1alpha+20120614-1

  -- no debconf information

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1234691/+subscriptions