[Bug 1252246] Re: Autopilot: assert window stack throughout install

[Dan Chapman]

** Changed in: ubiquity (Ubuntu)
     Assignee: (unassigned) => Dan Chapman (dpniel)

** Changed in: ubiquity (Ubuntu)
       Status: New => Fix Committed

** Branch linked: lp:~dpniel/ubiquity/autopilot

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubiquity in Ubuntu.
https://bugs.launchpad.net/bugs/1252246

Title:
  Autopilot: assert window stack throughout install

Status in “ubiquity” package in Ubuntu:
  Fix Committed

Bug description:
  At various points during the install we can come across various
  different error dialogs, this is hard to anticipate which dialog will
  appear at which point for what reason, therefore the current tests
  ignore this fact and only check for two error dialog during the
  progress bar section of the installation. Which polling on dbus for
  non existent dialogs is really hacky and horrible.

  We should rather use process manager to get the window stack and
  assert the visible window stack at the beginning and end of each page
  load and repeatedly during the progress bar section. If we catch that
  the window stack has changed it can only be a dialog that's appeared
  so selecting the visible dialog come up with a way to report which
  dialog appeared and the info it provides.

  Something along the lines of

  #at the start of the test on ubiquity loading get the visible window stack 
  visible_stack = self.process_manager.get_open_windows()  # returns a list of visible windows in stack order

  #then throughout the test use 
  self.assertVisibleWindowStack(visible_stack)

  we need to catch and handle the exception correctly so we can get the
  info we need before failing the test

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1252246/+subscriptions