[Bug 1239893] Re: PPAs added using GUI Software and Updates have an extra space added to repository line

[Alberto Salvia Novella]

** Changed in: hundredpapercuts
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to software-properties in Ubuntu.
https://bugs.launchpad.net/bugs/1239893

Title:
  PPAs added using GUI Software and Updates have an extra space added to
  repository line

Status in One Hundred Papercuts:
  Fix Released
Status in “software-properties” package in Ubuntu:
  Fix Released
Status in “software-properties” source package in Precise:
  Invalid
Status in “software-properties” source package in Saucy:
  Fix Released

Bug description:
  *********************
   GENERAL DESCRIPTION 
  *********************
  When I try to add a new PPA repository using Software and Updates gui the repository is added but software-properties-gtk adds an space to the line on /etc/apt/sources.list.d/ppa-name.list, as seen below:

  darkhole at devolo:/etc/apt/sources.list.d$ cat libreoffice-ppa_-saucy.list
  deb http://ppa.launchpad.net/libreoffice/ppa /ubuntu saucy main
  # deb-src http://ppa.launchpad.net/libreoffice/ppa /ubuntu saucy main

  The extra space is after the 'ppa' word.
  ppa file should be:

  deb http://ppa.launchpad.net/libreoffice/ppa/ubuntu saucy main
  # deb-src http://ppa.launchpad.net/libreoffice/ppa/ubuntu saucy main

  Using CLI method works fine (sudo add-apt-repository).

  I'm using Ubuntu 13.10 with latest updates. I have already tried
  multiple PPAs, with the same result.

  ********
   IMPACT 
  ********
  It is not possible to use a PPA added using the form 'ppa:lpuser/ppaname using software-properties-gtk' as an extra space is inserted in the sources line for the PPA.  This was due to the dropping of a strip() between versions 0.92.26 and 0.92.27.  The change just adds the strip() back.

  ***********
   TEST CASE
  ***********
  1. Open 'Software & Updates'.
  2. Go to 'Other Software' tab.
  3. Click on "Add..."
  4. In the 'APT Line' Textbox write the PPA repository (example: 'ppa:libreoffice/ppa').
  5. Click on "Add Source" button.
  6. Check the contents of the file created on /etc/apt/sources.list.d/ppa-name.list, you'll notice an a space between ppa /ubuntu.  Additionally the ppa-name.list file with have an underscore so 'ppa-name_.list'.

  *******************
   TECHNICAL DETAILS 
  *******************
  ProblemType: Bug
  DistroRelease: Ubuntu 13.10
  Package: software-properties-gtk 0.92.27
  ProcVersionSignature: Ubuntu 3.11.0-12.19-generic 3.11.3
  Uname: Linux 3.11.0-12-generic x86_64
  ApportVersion: 2.12.5-0ubuntu2
  Architecture: amd64
  Date: Mon Oct 14 20:12:36 2013
  InstallationDate: Installed on 2012-07-06 (465 days ago)
  InstallationMedia: Ubuntu 12.04 LTS "Precise Pangolin" - Release amd64 (20120425)
  MarkForUpload: True
  PackageArchitecture: all
  SourcePackage: software-properties
  SystemImageInfo: Error: [Errno 2] No existe el archivo o el directorio: 'system-image-cli'
  UpgradeStatus: Upgraded to saucy on 2013-01-20 (267 days ago)

To manage notifications about this bug go to:
https://bugs.launchpad.net/hundredpapercuts/+bug/1239893/+subscriptions