[Bug 637223] Re: hardy's init-functions has broken killproc

[Steve Langasek]

This seems to have never made it onto the radar while hardy was
supported, unfortunately.  Now that hardy is EOL, marking this bu
'wontfix'.

** Changed in: lsb (Ubuntu)
       Status: New => Won't Fix

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to lsb in Ubuntu.
https://bugs.launchpad.net/bugs/637223

Title:
  hardy's init-functions has broken killproc

Status in “lsb” package in Ubuntu:
  Won't Fix

Bug description:
  Binary package hint: lsb

  The hardy version of killproc in init-functions is broken:

  
  |     sig=$(echo ${2:-} | sed -e 's/^-\(.*\)/\1/')
  |     sig=$(echo $sig | sed -e 's/^SIG\(.*\)/\1/')
  |     if [ -n "$sig" -o "$sig" = 15 -o "$sig" = TERM ]; then
  |         is_term_sig=yes
  |     fi

  The -n should be -z as it is in later versions of Ubuntu.  This bug
  causes packages which use the killproc function to try and send a
  signal (e.g. HUP to reload) to always SIGTERM the process instead.

  This was reported in Debian as #478871:

   <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=478871>

  Attached is the trivial/obvious patch to fix this.  Could we please
  get this or something like it into an SRU?

  --- init-functions.orig	2010-09-13 15:20:52.000000000 +0100
  +++ init-functions	2010-09-13 15:23:25.000000000 +0100
  @@ -120,7 +120,7 @@
   
       sig=$(echo ${2:-} | sed -e 's/^-\(.*\)/\1/')
       sig=$(echo $sig | sed -e 's/^SIG\(.*\)/\1/')
  -    if [ -n "$sig" -o "$sig" = 15 -o "$sig" = TERM ]; then
  +    if [ -z "$sig" -o "$sig" = 15 -o "$sig" = TERM ]; then
           is_term_sig=yes
       fi
       status=0

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lsb/+bug/637223/+subscriptions