[Bug 1192864] Re: shadow: please include user name space patches

[Seth Arnold]

Hello Dmitrijs,

Full details of my review can be found at
http://lists.alioth.debian.org/pipermail/pkg-shadow-
devel/2013-June/009752.html

To summarize here, find_new_sub_gids(), find_new_sub_uids(), and
get_map_ranges() need some additional parameter checks to enforce some
invariants necessary for sane execution. Since these are setuid helpers,
an abundance of caution is prudent.

There is no need to ask for further review once these checks are in
place -- the changes will be small and simple.

Conditional upon the above modifications, ACK.

Thanks.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to shadow in Ubuntu.
https://bugs.launchpad.net/bugs/1192864

Title:
  shadow: please include user name space patches

Status in “shadow” package in Ubuntu:
  Confirmed

Bug description:
  Please upload shadow with user namespace patches.

  dget http://ppa.launchpad.net/serge-hallyn/userns-
  natty/ubuntu/pool/main/s/shadow/shadow_4.1.5.1-1ubuntu4userns1.dsc

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/shadow/+bug/1192864/+subscriptions