[Bug 234123] Re: Cannot use "edit" command inside lftp

[Daniel Karlsson]

Thank you for taking the time to report this bug and helping to make
Ubuntu better. We are sorry that we do not always have the capacity to
look at all reported bugs in a timely manner. There have been many
changes in Ubuntu since that time you reported the bug and your problem
may have been fixed with some of the updates. It would help us a lot if
you could test it on a currently supported Ubuntu version. When you test
it and it is still an issue, kindly upload the updated logs by running
apport-collect 234123 and any other logs that are relevant for this
particular issue.

** Changed in: lftp (Ubuntu)
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to lftp in Ubuntu.
https://bugs.launchpad.net/bugs/234123

Title:
  Cannot use "edit" command inside lftp

Status in “lftp” package in Ubuntu:
  Incomplete

Bug description:
  Binary package hint: lftp

  Hi,

  I'm using LFTP 3.7.1, and the "edit" command doesn't work.

  edit is an alias for `eval -f "get $0 -o ~/.lftp/edit.tmp.$$ && shell
  \"cp -p ~/.lftp/edit.tmp.$$ ~/.lftp/edit.tmp.$$.orig && $EDITOR
  ~/.lftp/edit.tmp.$$ && test ~/.lftp/edit.tmp.$$ -nt
  ~/.lftp/edit.tmp.$$.orig\" && put ~/.lftp/edit.tmp.$$ -o $0; shell rm
  -f ~/.lftp/edit.tmp.$$*"'

  This doesn't work because $EDITOR is empty.

  The eval should test for it (test -z $EDITOR), or a script you get
  from a site with the execution bit set could be potentially be
  executed! See: "$EDITOR ~/.lftp/edit.tmp.$$" ==>"~/.lftp/edit.tmp.$$"

  So, we could change the eval to something like (untested):

  'eval -f "shell \"test -z \\"$EDITOR\\" && echo \'Variable $EDITOR is
  not set.\' && exit -1;\" || get $0 -o ~/.lftp/edit.tmp.$$ && shell
  \"cp -p ~/.lftp/edit.tmp.$$ ~/.lftp/edit.tmp.$$.orig && \"$EDITOR\"
  ~/.lftp/edit.tmp.$$ && test ~/.lftp/edit.tmp.$$ -nt
  ~/.lftp/edit.tmp.$$.orig\" && put ~/.lftp/edit.tmp.$$ -o $0; shell rm
  -f ~/.lftp/edit.tmp.$$*;"'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lftp/+bug/234123/+subscriptions