[Bug 1187808] Re: PreserveFQDN fix introduces regression that might cause rsyslog not to start

[Steve Langasek]

I've reproduced the original bug in raring, and verified that the
package in -proposed fixes the issue, allowing rsyslog to start.

I have not reproduced the original bug in precise, but have verified
that after upgrade the new version of rsyslog still starts correctly.

Considering this verified.

** Tags removed: verification-needed
** Tags added: verification-done

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to rsyslog in Ubuntu.
https://bugs.launchpad.net/bugs/1187808

Title:
  PreserveFQDN fix introduces regression that might cause rsyslog not to
  start

Status in “rsyslog” package in Ubuntu:
  Fix Released
Status in “rsyslog” source package in Precise:
  Fix Committed
Status in “rsyslog” source package in Raring:
  Fix Committed

Bug description:
  LP: #1022545 fix introduced a regression that might cause rsyslog not
  to start, even though the upstream commit seems to claim otherwise :

  ChangeLog
    A temporary buffer was allocated one byte too small. Did only
    affect startup, not actual operations. Came up during routine tests,
    and can have no effect once the engine runs. Bug was introduced in
    7.3.11.

  [Impact]
  As reported in duplicate bug #1187876, this issue causes rsyslog to fail to start in some circumstances due to the resulting malloc corruption, which may cause cloud instances to fail to configure themselves correctly on boot.  This is a critical regression introduced in an SRU.

  [Test case]
  1. reproduce the error with rsyslog failing to start, with errors written to /var/log/upstart/rsyslog.log:
  *** Error in `rsyslogd': malloc(): memory corruption: 0x00000000007b2930 ***
  and verify that 'status rsyslog' shows 'start/spawned' instead of 'start/running'.
  2. kill any lingering rsyslog processes with 'sudo killall rsyslogd && sudo stop rsyslog'.
  3. upgrade to the -proposed version of the package.
  4. verify that rsyslogd is now running ('status rsyslog' shows 'start/running').

  [Regression potential]
  Minimal.  This is a targeted one-character fix for a regression introduced in the previous SRU.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rsyslog/+bug/1187808/+subscriptions