[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

[Brian Murray]

There are two points in show_diff from aptdaemon/gtk3widgets.py where
line_number is not defined:

        for line in difflib.unified_diff(from_lines, to_lines, lineterm=""):
            if line.startswith("@@"):
                match = re.match(self.REGEX_RANGE, line)
                if not match:
                    continue
                line_number = int(match.group("from_start"))
                if line_number > 1:
                    insert_tagged_text(iter, self.ELLIPSIS, "default")
            elif line.startswith("---") or line.startswith("+++"):
                continue
            elif line.startswith(" "):
                line_number += 1
                insert_tagged_text(iter, str(line_number), "number")
                insert_tagged_text(iter, line, "default")
            elif line.startswith("-"):
                line_number += 1
                insert_tagged_text(iter, str(line_number), "number")
                insert_tagged_text(iter, line, "remove")

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to aptdaemon in Ubuntu.
https://bugs.launchpad.net/bugs/1120322

Title:
  update-manager crashed with UnboundLocalError in show_diff(): local
  variable 'line_number' referenced before assignment

Status in “aptdaemon” package in Ubuntu:
  Triaged
Status in “aptdaemon” source package in Precise:
  Triaged

Bug description:
  At the same time as the crash appeared, I got a box for Keep/Renew Steam config file. 
  I was however no able to click on either Keep/Renew.

  ProblemType: Crash
  DistroRelease: Ubuntu 13.04
  Package: update-manager 1:0.181
  ProcVersionSignature: Ubuntu 3.8.0-4.8-generic 3.8.0-rc6
  Uname: Linux 3.8.0-4-generic x86_64
  NonfreeKernelModules: nvidia
  ApportVersion: 2.8-0ubuntu4
  Architecture: amd64
  Date: Sat Feb  9 14:05:09 2013
  ExecutablePath: /usr/bin/update-manager
  GsettingsChanges:
   b'com.ubuntu.update-manager' b'first-run' b'false'
   b'com.ubuntu.update-manager' b'launch-time' b'1360363834'
   b'com.ubuntu.update-manager' b'show-details' b'true'
   b'com.ubuntu.update-manager' b'window-height' b'625'
   b'com.ubuntu.update-manager' b'window-width' b'591'
  InstallationDate: Installed on 2012-08-22 (170 days ago)
  InstallationMedia: Ubuntu 12.04 LTS "Precise Pangolin" - Release amd64 (20120425)
  InterpreterPath: /usr/bin/python3.3
  MarkForUpload: True
  PackageArchitecture: all
  ProcCmdline: /usr/bin/python3 /usr/bin/update-manager
  ProcEnviron:
   LANGUAGE=nb_NO:nb:no_NO:no:nn_NO:nn:en
   PATH=(custom, no user)
   XDG_RUNTIME_DIR=<set>
   LANG=nb_NO.UTF-8
   SHELL=/bin/bash
  PythonArgs: ['/usr/bin/update-manager']
  SourcePackage: update-manager
  Title: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment
  UpgradeStatus: Upgraded to raring on 2013-01-22 (18 days ago)
  UserGroups: adm cdrom dialout dip lpadmin plugdev sambashare sudo tty

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/aptdaemon/+bug/1120322/+subscriptions