[Bug 1123192] Re: open-iscsi removes modules on stop but should not

[Alex Bligh]

Actually one problem we are seeing should be pretty universal.

When using OCFS2, it will open the shared iSCSI device with O_DIRECT,
and write a heartbeat there. If this errors, then the node self fences
(i.e. reboots).

If the open-iscsi package is upgraded, it calls the init with a stop
method, then the start method. There may be a gap between these two if
lots of packages are being upgraded.

It's actually not just the modprobes that are the problem here, it's the
fact that it logs out of all iscsi targets WHETHER OR NOT THEY ARE IN
THE CONFIG FILE which is the issue. In one scenario here we aren't using
the config file at all - we're calling iscsiadm or equivalent to mount
the LUNs directly.

What should be happening here I think is it shutting down the daemon and
arguably stopping the targets it started on boot. I don't see why it's
interfering with other targets it had nothing to do with starting. Or at
least there should be some /etc/default type setting that says 'please
don't interfere with running targets'.

What happens if your root directory is on iscsi? (serious question - I'm
interested in how it's meant to cope)

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to open-iscsi in Ubuntu.
https://bugs.launchpad.net/bugs/1123192

Title:
  open-iscsi removes modules on stop but should not

Status in “open-iscsi” package in Ubuntu:
  New

Bug description:
  open-iscsi's stop script has within it the following lines:

  stop() {
          stoptargets
          log_daemon_msg "Stopping iSCSI initiator service"
          start-stop-daemon --stop --quiet --signal KILL --exec $DAEMON
          rm -f $PIDFILE /lib/init/rw/sendsigs.omit.d/`basename $PIDFILE`
          modprobe -r ib_iser 2>/dev/null
          modprobe -r iscsi_tcp 2>/dev/null
          log_end_msg 0
  }

  
  The modprobe -r lines attempt to remove the relevant iscsi modules. I believe this to be a bug, because there may be other users of those modules besides open-iscsi. On an upgrade (for instance) and attempt is made to remove those modules (albeit ignoring errors), and then modprobe them back in again. However, those modules are not distributed in the open-iscsi package - they are kernel modules - and open-iscsi has no business removing them as there may be other users using them in the mean time.

  I can see no reason why they are being removed at all.

  A simple fix is to remove the two 'modprobe -r' lines from debian
  /open-iscsi.init.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1123192/+subscriptions