[Bug 1123192] [NEW] open-iscsi removes modules on stop but should not

[Ritesh Raj Sarraf]

What other users are you talking about?
On Feb 12, 2013 9:30 PM, "Alex Bligh" <ubuntu at alex.org.uk> wrote:

> Public bug reported:
>
> open-iscsi's stop script has within it the following lines:
>
> stop() {
>         stoptargets
>         log_daemon_msg "Stopping iSCSI initiator service"
>         start-stop-daemon --stop --quiet --signal KILL --exec $DAEMON
>         rm -f $PIDFILE /lib/init/rw/sendsigs.omit.d/`basename $PIDFILE`
>         modprobe -r ib_iser 2>/dev/null
>         modprobe -r iscsi_tcp 2>/dev/null
>         log_end_msg 0
> }
>
>
> The modprobe -r lines attempt to remove the relevant iscsi modules. I
> believe this to be a bug, because there may be other users of those modules
> besides open-iscsi. On an upgrade (for instance) and attempt is made to
> remove those modules (albeit ignoring errors), and then modprobe them back
> in again. However, those modules are not distributed in the open-iscsi
> package - they are kernel modules - and open-iscsi has no business removing
> them as there may be other users using them in the mean time.
>
> I can see no reason why they are being removed at all.
>
> A simple fix is to remove the two 'modprobe -r' lines from debian/open-
> iscsi.init.
>
> ** Affects: open-iscsi (Ubuntu)
>      Importance: Undecided
>          Status: New
>
> --
> You received this bug notification because you are subscribed to open-
> iscsi in Ubuntu.
> https://bugs.launchpad.net/bugs/1123192
>
> Title:
>   open-iscsi removes modules on stop but should not
>
> Status in “open-iscsi” package in Ubuntu:
>   New
>
> Bug description:
>   open-iscsi's stop script has within it the following lines:
>
>   stop() {
>           stoptargets
>           log_daemon_msg "Stopping iSCSI initiator service"
>           start-stop-daemon --stop --quiet --signal KILL --exec $DAEMON
>           rm -f $PIDFILE /lib/init/rw/sendsigs.omit.d/`basename $PIDFILE`
>           modprobe -r ib_iser 2>/dev/null
>           modprobe -r iscsi_tcp 2>/dev/null
>           log_end_msg 0
>   }
>
>
>   The modprobe -r lines attempt to remove the relevant iscsi modules. I
> believe this to be a bug, because there may be other users of those modules
> besides open-iscsi. On an upgrade (for instance) and attempt is made to
> remove those modules (albeit ignoring errors), and then modprobe them back
> in again. However, those modules are not distributed in the open-iscsi
> package - they are kernel modules - and open-iscsi has no business removing
> them as there may be other users using them in the mean time.
>
>   I can see no reason why they are being removed at all.
>
>   A simple fix is to remove the two 'modprobe -r' lines from debian
>   /open-iscsi.init.
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1123192/+subscriptions
>

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to open-iscsi in Ubuntu.
https://bugs.launchpad.net/bugs/1123192

Title:
  open-iscsi removes modules on stop but should not

Status in “open-iscsi” package in Ubuntu:
  New

Bug description:
  open-iscsi's stop script has within it the following lines:

  stop() {
          stoptargets
          log_daemon_msg "Stopping iSCSI initiator service"
          start-stop-daemon --stop --quiet --signal KILL --exec $DAEMON
          rm -f $PIDFILE /lib/init/rw/sendsigs.omit.d/`basename $PIDFILE`
          modprobe -r ib_iser 2>/dev/null
          modprobe -r iscsi_tcp 2>/dev/null
          log_end_msg 0
  }

  
  The modprobe -r lines attempt to remove the relevant iscsi modules. I believe this to be a bug, because there may be other users of those modules besides open-iscsi. On an upgrade (for instance) and attempt is made to remove those modules (albeit ignoring errors), and then modprobe them back in again. However, those modules are not distributed in the open-iscsi package - they are kernel modules - and open-iscsi has no business removing them as there may be other users using them in the mean time.

  I can see no reason why they are being removed at all.

  A simple fix is to remove the two 'modprobe -r' lines from debian
  /open-iscsi.init.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1123192/+subscriptions