[Bug 1258112] Re: Try calling unexisting functions on GtkDialog
Dylan McCall
dylanmccall at gmail.com
Sat Dec 7 02:49:39 UTC 2013
This looks like a bug in apturl. It calls into Update Manager's Python
modules with its own bogus 'window_main' object (which happens to
provide a similar interface to Update Manager, until recently). I didn't
realize this was happening when I originally refactored it: I'd been
working on the assumption that Update Manager's code was all private.
Sorry about that!
Frankly, though, this seems very broken on apturl's part, and from a
cursory glance I don't think its sane to fix it from update-manager's
end. I had submitted a few patches to apturl for an earlier issue, so
this could be patched over in a similar fashion: copy the missing
interface into apturl's monstrous 'UpdateManager' / 'window_main'
lookalike and run away before it gains sentience.
Can someone explain why it is structured this way? I feel like we'd be
better off if apturl just used PackageKit directly, or if we're going to
reuse this dialog for some reason if it at least launched Update Manager
over the command line instead of using Python modules from other
applications that (as far as I can tell) carry no guarantees for
portability.
--
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-manager in Ubuntu.
https://bugs.launchpad.net/bugs/1258112
Title:
Try calling unexisting functions on GtkDialog
Status in “apturl” package in Ubuntu:
New
Status in “update-manager” package in Ubuntu:
Confirmed
Bug description:
That's a side effect of the refactoring which has been done in
https://code.launchpad.net/~dylanmccall/update-manager/dialogs-
refactor/+merge/164673
_action_done() is calling "self.window_main.start_available/error", or
window_main is a GtkDialog not an UpdateManager object anymore, so it
doesn't have those functions...
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apturl/+bug/1258112/+subscriptions
More information about the foundations-bugs
mailing list