[Bug 1251604] Re: "click build -m" crashes when given a directory

[Colin Watson]

The intent is that you should pass a file name, not a directory name.
But of course we can make it more robust against this.

** Summary changed:

- Using the build -m option crashes click.
+ "click build -m" crashes when given a directory

** Changed in: click (Ubuntu)
       Status: New => Triaged

** Changed in: click (Ubuntu)
   Importance: Undecided => Low

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to click in Ubuntu.
https://bugs.launchpad.net/bugs/1251604

Title:
  "click build -m" crashes when given a directory

Status in “click” package in Ubuntu:
  Triaged

Bug description:
  To reproduce:

  In current dir have:
      manifest.json
      foo/

  Directory "foo" contains the files to be packaged.

  Run: "click build -m . foo/"

  Expected result: click should build a click package using the
  manifest.json in current directory.

  Actual Result: click crashes with the following backtrace:

  Traceback (most recent call last):
    File "/usr/bin/click", line 83, in <module>
      sys.exit(main())
    File "/usr/bin/click", line 79, in main
      return mod.run(args)
    File "/usr/lib/python3/dist-packages/click/commands/build.py", line 45, in run
      path = builder.build(".", manifest_path=options.manifest)
    File "/usr/lib/python3/dist-packages/click/build.py", line 212, in build
      self.read_manifest(full_manifest_path)
    File "/usr/lib/python3/dist-packages/click/build.py", line 79, in read_manifest
      with io.open(manifest_path, encoding="UTF-8") as manifest:
  IsADirectoryError: [Errno 21] Is a directory: '/tmp/clickp4o0vn/data/.'
  --- 
  ApportVersion: 2.12.5-0ubuntu2.1
  Architecture: amd64
  DistroRelease: Ubuntu 13.10
  InstallationDate: Installed on 2013-08-27 (79 days ago)
  InstallationMedia: Xubuntu 13.10 "Saucy Salamander" - Alpha amd64 (20130827)
  MarkForUpload: True
  NonfreeKernelModules: nvidia
  Package: click 0.4.11
  PackageArchitecture: amd64
  Tags:  saucy
  Uname: Linux 3.11.0-031100-generic x86_64
  UpgradeStatus: No upgrade log present (probably fresh install)
  UserGroups: adm cdrom dip lpadmin plugdev sambashare sudo vboxusers video

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/click/+bug/1251604/+subscriptions