[Bug 1213748] [NEW] accessibility indicator in only-ubiquity

[Jim Paris]

Public bug reported:

I didn't experience this bug, but I was looking through the code and
just noticed that it can't work as intended.  This is from rev 5600:

--- bin/ubiquity-dm	2012-07-16 14:29:13 +0000
+++ bin/ubiquity-dm	2012-08-20 05:17:16 +0000
@@ -359,6 +359,7 @@
             # Accessibility infrastructure
             with open('/proc/cmdline', 'r') as fp:
                 if (accessibility or 'maybe-ubiquity' in fp.readline() or
+                    'only-ubiquity' in fp.readline() or
                     program_basename == 'oem-config-wrapper'):
                     launcher = '/usr/lib/at-spi2-core/at-spi-bus-launcher'
                     if os.path.exists(launcher):

You can't call fp.readline() twice like that... the second call will
always return an empty string because /proc/cmdline only has one line.

** Affects: ubiquity (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubiquity in Ubuntu.
https://bugs.launchpad.net/bugs/1213748

Title:
  accessibility indicator in only-ubiquity

Status in “ubiquity” package in Ubuntu:
  New

Bug description:
  I didn't experience this bug, but I was looking through the code and
  just noticed that it can't work as intended.  This is from rev 5600:

  --- bin/ubiquity-dm	2012-07-16 14:29:13 +0000
  +++ bin/ubiquity-dm	2012-08-20 05:17:16 +0000
  @@ -359,6 +359,7 @@
               # Accessibility infrastructure
               with open('/proc/cmdline', 'r') as fp:
                   if (accessibility or 'maybe-ubiquity' in fp.readline() or
  +                    'only-ubiquity' in fp.readline() or
                       program_basename == 'oem-config-wrapper'):
                       launcher = '/usr/lib/at-spi2-core/at-spi-bus-launcher'
                       if os.path.exists(launcher):

  You can't call fp.readline() twice like that... the second call will
  always return an empty string because /proc/cmdline only has one line.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1213748/+subscriptions