[Bug 1212208] [NEW] quilt patches are not applied during --unbuilt-tree build

[Robie Basak]

Public bug reported:

Steps to reproduce:

1. Pick a "3.0 (quilt) package" and unpack the source directory.
2. Run "quilt pop -a"
3. Run adt-run --unbuilt-tree against this source directory.

Expected results: adt-run builds the source correctly, including an initial "quilt push -a" in its build area.
Actual results: the package is built and tested without patches being applied.

adt-run(1) says:

       --unbuilt-tree directory
              Specifies that tests from the unbuilt source tree directory should be run.  This is  very  similar  to
              specifing  --source  except that a directory tree (which should be pristine) is supplied, instead of a
              source package.

It doesn't specify that patches will be applied, but "which should be
pristine" is a bit ambiguous here. I'm not sure that it ever makes sense
to build a package without quilt patches applied, and it is quite
confusing and hard to track down when this happens. Please detect "3.0
(quilt)" and apply all patches by default.

** Affects: autopkgtest (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to autopkgtest in Ubuntu.
https://bugs.launchpad.net/bugs/1212208

Title:
  quilt patches are not applied during --unbuilt-tree build

Status in “autopkgtest” package in Ubuntu:
  New

Bug description:
  Steps to reproduce:

  1. Pick a "3.0 (quilt) package" and unpack the source directory.
  2. Run "quilt pop -a"
  3. Run adt-run --unbuilt-tree against this source directory.

  Expected results: adt-run builds the source correctly, including an initial "quilt push -a" in its build area.
  Actual results: the package is built and tested without patches being applied.

  adt-run(1) says:

         --unbuilt-tree directory
                Specifies that tests from the unbuilt source tree directory should be run.  This is  very  similar  to
                specifing  --source  except that a directory tree (which should be pristine) is supplied, instead of a
                source package.

  It doesn't specify that patches will be applied, but "which should be
  pristine" is a bit ambiguous here. I'm not sure that it ever makes
  sense to build a package without quilt patches applied, and it is
  quite confusing and hard to track down when this happens. Please
  detect "3.0 (quilt)" and apply all patches by default.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/autopkgtest/+bug/1212208/+subscriptions