[Bug 1160288] Re: uninitialized value $3 / $curmod

[Steve Langasek]

I think this should do the job:

--- debian/local/pam-auth-update	2011-10-30 19:06:55 +0000
+++ debian/local/pam-auth-update	2013-04-15 19:06:23 +0000
@@ -686,7 +686,7 @@
 		} else {
 			chomp;
 			s/^\s+//;
-			$profile{$fieldname} .= "\n$_";
+			$profile{$fieldname} .= "\n$_" if ($_);
 			$profile{$fieldname} =~ s/^[\n\s]+//;
 		}
 	}


** Changed in: pam (Ubuntu)
       Status: Triaged => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to pam in Ubuntu.
https://bugs.launchpad.net/bugs/1160288

Title:
  uninitialized value $3 / $curmod

Status in “pam” package in Ubuntu:
  Fix Committed

Bug description:
  [impact]
  Call of pam-auth-update raises some warnings of uninitalized variables

  [test case]
  install sssd libpam-sss libnss-sss and run pam-auth-update

  [versions]
  Distributor ID: Ubuntu
  Description:    Ubuntu 12.04.2 LTS
  Release:        12.04
  Codename:       precise

  libpam-runtime
  1.1.3-7ubuntu2

  
  [possible solution]
  --- a/pam-auth-update   Tue Mar 26 11:05:37 2013 +0100
  +++ b/pam-auth-update   Tue Mar 26 11:05:56 2013 +0100
  @@ -620,8 +620,8 @@
                                  ($modname,$line) = @{$saved[0]};
                                  shift(@saved);
                                  $line =~ /^((\[[^]]+\]|\w+)\s+\S+)\s*(.*)/;
  -                               @prev_opts = split(/\s+/,$3);
  -                               $curmod = $1;
  +                               @prev_opts = split(/\s+/, (defined $3?$3:"") );
  +                               $curmod = (defined $1?$1:"");
                                  # FIXME: the key isn't derived from the config
                                  # name, so collisions are possible if more
                                  # than one config references the same module

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pam/+bug/1160288/+subscriptions