[Bug 1053792] [NEW] ubuntu patch 04_changelog broken, ill-defined scope, out-of-date

[Daniel Hartwig]

Public bug reported:

ubuntu patch 04_changelog

This change is completely broken:

--- a/src/apt_options.cc
+++ b/src/apt_options.cc
-	      "http://cgi.debian.org/cgi-bin/get-changelog?package=%s"),
+	      "http://changelogs.ubuntu.com/changelogs/pool/%s/%s/%s/%s_%s/changelog"),

It changes the meaning of the template parameter and introduces new
parameters.  There is nowhere in the patch where the consumer of this
template is updated.  The combination of these two points is bad, very
bad, but ok in this case–by default–as the template in question has not
been used since ancient history.  None-the-less, the above change is
absolutely wrong: should the use of this template be re-introduced
Ubuntu users are at-risk of having broken values for it in their custom
configuration.

Remove that change.

The patch also includes changes to interface strings which overlap the
scope of 03_branding.  Please move those changes there and keep
04_changelog exclusive to modifying which server is used.

--
Package: aptitude
Version: 0.6.8ubuntu1

** Affects: aptitude (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to aptitude in Ubuntu.
https://bugs.launchpad.net/bugs/1053792

Title:
  ubuntu patch 04_changelog broken, ill-defined scope, out-of-date

Status in “aptitude” package in Ubuntu:
  New

Bug description:
  ubuntu patch 04_changelog

  This change is completely broken:

  --- a/src/apt_options.cc
  +++ b/src/apt_options.cc
  -	      "http://cgi.debian.org/cgi-bin/get-changelog?package=%s"),
  +	      "http://changelogs.ubuntu.com/changelogs/pool/%s/%s/%s/%s_%s/changelog"),

  It changes the meaning of the template parameter and introduces new
  parameters.  There is nowhere in the patch where the consumer of this
  template is updated.  The combination of these two points is bad, very
  bad, but ok in this case–by default–as the template in question has
  not been used since ancient history.  None-the-less, the above change
  is absolutely wrong: should the use of this template be re-introduced
  Ubuntu users are at-risk of having broken values for it in their
  custom configuration.

  Remove that change.

  The patch also includes changes to interface strings which overlap the
  scope of 03_branding.  Please move those changes there and keep
  04_changelog exclusive to modifying which server is used.

  --
  Package: aptitude
  Version: 0.6.8ubuntu1

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/aptitude/+bug/1053792/+subscriptions