[Bug 1011093] Re: Changelog URL parsing not working correctly
Launchpad Bug Tracker
1011093 at bugs.launchpad.net
Wed Sep 19 18:10:10 UTC 2012
This bug was fixed in the package update-manager - 1:0.174
update-manager (1:0.174) quantal; urgency=low
* UpdateManager/ChangelogViewer.py: improve url parsing of changelog files
so that more links are created. Thanks to sampo555 for the patch
* Add a dependency to update-manager on update-notifier (LP: #1043725)
-- Brian Murray <brian at ubuntu.com> Wed, 19 Sep 2012 09:56:12 -0700
** Changed in: update-manager (Ubuntu)
Status: Triaged => Fix Released
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-manager in Ubuntu.
Changelog URL parsing not working correctly
Status in “update-manager” package in Ubuntu:
The URL parser doesn't parse all entries it should from the changelog.
As the searching is started from the beginning of the changelog
('iter' variable set to the start), Software Updater takes the first
search term and tries to find a match from the changelog starting from
position defined by the 'iter' variable. If/when a match is found,
Software Updater determines the end of the expression and inserts tag
over that expression. Once the part of the changelog is tagged, 'iter'
is set to the end of the match and search continues until there's no
more matches. Then the next search term is picked up and the process
starts with new search term.
However because the 'iter' variable was just set to the end of the
last match, the searching doesn't start from the beginning of the
changelog - it starts at the end of last found match because variable
'iter' is currently pointing there. This makes the Software Updater to
miss some links it could show to the user. This problem can be seen by
running 'python UpdateManager/ChangelogViewer.py' (the http link is
tagged but LP: #XXX above it isn't).
The worst case scenario is that there's an http adress at the end of
the changelog. Because 'http' is the first search term, Software
Updater finds the link, tags in and sets 'iter' variable point to the
end of the changelog. After this none of the other matches Software
Updater could tag (like all LP: #XXXXXX, Closes #YYYYYY etc.) are
tagged because the searching always starts from the end and there's
nothing to find.
I've attached a patch that should fix this problem (it restores 'iter'
back to the beginning every time new search term is selected).
This bug happens in Quantal but as the code is same as in Precise it
should be happening there too.
To manage notifications about this bug go to:
More information about the foundations-bugs