[Bug 1037916] Re: add-apt-repository doesn't add ppa if file with comments exists

[Launchpad Bug Tracker]

** Branch linked: lp:~sampo555/software-properties/fix-1037916

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to software-properties in Ubuntu.
https://bugs.launchpad.net/bugs/1037916

Title:
  add-apt-repository doesn't add ppa if file with comments exists

Status in “software-properties” package in Ubuntu:
  Confirmed

Bug description:
  add-apt-repository fails to add a ppa if the file for the ppa already
  exists with the deb entries commented out. Besides this, it doesn't
  print any error message and returns success (0).

  One way to reproduce it is as follows:
  - Add PPA to sources
  $ sudo add-apt-repository -y ppa:javier.collado/ppa

  $ cat /etc/apt/sources.list.d/javier_collado-ppa-quantal.list 
  deb http://ppa.launchpad.net/javier.collado/ppa/ubuntu quantal main
  deb-src http://ppa.launchpad.net/javier.collado/ppa/ubuntu quantal main

  - Remove PPA from sources
  $ sudo ppa-purge ppa:javier.collado/ppa

  $ cat /etc/apt/sources.list.d/javier_collado-ppa-quantal.list 
  # deb http://ppa.launchpad.net/javier.collado/ppa/ubuntu quantal main
  # deb-src http://ppa.launchpad.net/javier.collado/ppa/ubuntu quantal main

  - Add again PPA to sources
  $ sudo add-apt-repository -y ppa:javier.collado/ppa
  Executing: gpg --ignore-time-conflict --no-options --no-default-keyring --secret-keyring /tmp/tmp.Kekxq78ff1 --trustdb-name /etc/apt//trustdb.gpg --keyring /etc/apt/trusted.gpg --primary-keyring /etc/apt/trusted.gpg --keyserver hkp://keyserver.ubuntu.com:80/ --recv 36AA079422DB186A78174271FFD1BF24CF31078F
  gpg: requesting key CF31078F from hkp server keyserver.ubuntu.com
  gpg: key CF31078F: "Launchpad PPA for Javier Collado" not changed
  gpg: Total number processed: 1
  gpg:              unchanged: 1

  - PPA wasn't really added
  $ cat /etc/apt/sources.list.d/javier_collado-ppa-quantal.list 
  # deb http://ppa.launchpad.net/javier.collado/ppa/ubuntu quantal main
  # deb-src http://ppa.launchpad.net/javier.collado/ppa/ubuntu quantal main

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1037916/+subscriptions