[Bug 683640] Re: status_of_proc is returning incorrect error code

[Adam Conrad]

Hello Psi-Jack, or anyone else affected,

Accepted lsb into lucid-proposed. The package will build now and be
available at http://launchpad.net/ubuntu/+source/lsb/4.0-0ubuntu8.1 in a
few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed.  Your feedback will aid us getting this update
out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from
verification-needed to verification-done.  If it does not, change the
tag to verification-failed.  In either case, details of your testing
will help us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: lsb (Ubuntu Lucid)
       Status: Confirmed => Fix Committed

** Tags added: verification-needed

** Changed in: lsb (Ubuntu Precise)
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to lsb in Ubuntu.
https://bugs.launchpad.net/bugs/683640

Title:
  status_of_proc is returning incorrect error code

Status in “lsb” package in Ubuntu:
  Fix Released
Status in “lsb” source package in Lucid:
  Fix Committed
Status in “lsb” source package in Natty:
  Won't Fix
Status in “lsb” source package in Oneiric:
  Won't Fix
Status in “lsb” source package in Precise:
  Fix Committed
Status in “lsb” source package in Quantal:
  Fix Released

Bug description:
  Binary package hint: lsb

  [Impact]
  When status_of_proc is called with -p $PIDFILE and the service is not presently started, error code 4 is always returned because the process does not have the PID file existant until it is started, and it's deleted after stopping.

  This fails LSB compliance because it should report 0 if the service is
  stopped as expected.

  [Test Case]
  status_of_proc should /optionally/ check if a pid file exists or not, not make it mandatory to exist before throwing an error code. If pid file does exist, check it, verify it's associated with $DAEMON, and if not try to determine if the process is actually running under a different pid, if not, then return error code 0 because it is determined that it is /not/ running.

  Error code 4 in LSB is reserved for total permanent failure that
  requires manual intervention to correct. Such as, the process daemon
  isn't executable due to permissions, or it tried to start but fails..
  error code 4 is likely never used on checking status is very basic.
  Either it's running, or it's not. That's all status_of_proc should
  report, nothing more, nothing less.

  [Regression]
  Minimal, changes the behavior of checking against a pid file existance.

  ProblemType: Bug
  DistroRelease: Ubuntu 10.04
  Package: lsb-base 4.0-0ubuntu8
  ProcVersionSignature: Ubuntu 2.6.32-26.48-server 2.6.32.24+drm33.11
  Uname: Linux 2.6.32-26-server x86_64
  Architecture: amd64
  Date: Wed Dec  1 08:27:21 2010
  InstallationMedia: Ubuntu-Server 10.04.1 LTS "Lucid Lynx" - Release amd64 (20100816.2)
  PackageArchitecture: all
  ProcEnviron:
   LANG=en_US.UTF-8
   SHELL=/bin/bash
  SourcePackage: lsb

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lsb/+bug/683640/+subscriptions