[Bug 1036283] Re: callgrind_control cannot connect because of different executable name

[Julian Taylor]

** Description changed:

- When starting a Callgrind session using "valgrind", the actual
- executable name is "valgrind.bin". However, when callgrind_control
- searches for processes, its Perl regexp does not allow for this
- possibility. See callgrind_control line 32:
+ [Impact]
+ When starting a Callgrind session using "valgrind", the actual executable name is "valgrind.bin". However, when callgrind_control searches for processes, its Perl regexp does not allow for this possibility. See callgrind_control line 32:
+ Additionally the code contains several buffer overflows that can break depending on compiler optimizations.
  
-   if (/^use --pid=(\d+) for \S*?valgrind\s+(.*?)\s*$/) {
+ [TESTCASE]
+   $ valgrind --tool=callgrind sleep 100 &
+   $ callgrind_control -b
+   No active callgrind runs detected.
+ After making the change:
+   $ valgrind --tool
+   $ callgrind_control -b
+   PID 23522: sleep 100
  
- Callgrind_control works as expected again after changing this line to:
+ [Regression Potential]
+ the program currently doesn't work properly so there is little risk of things getting worse.
+ The overflow fixes are applied upstream since several month and the process name fix is also in debian wheezy.
  
-   if (/^use --pid=(\d+) for \S*?valgrind(?:\.bin)?\s+(.*?)\s*$/) {
- 
- Please make this change in your package (or upstream).
- 
- Steps to reproduce:
-   $ valgrind --tool=callgrind sleep 100 &
-   $ callgrind_control -b
-   No active callgrind runs detected.
- After making the change:
-   $ valgrind --tool
-   $ callgrind_control -b
-   PID 23522: sleep 100
  
  ProblemType: Bug
  DistroRelease: Ubuntu 12.04
  Package: valgrind 1:3.7.0-0ubuntu3
  ProcVersionSignature: Ubuntu 3.2.0-27.43-generic 3.2.21
  Uname: Linux 3.2.0-27-generic x86_64
  NonfreeKernelModules: fglrx
  ApportVersion: 2.0.1-0ubuntu11
  Architecture: amd64
  Date: Mon Aug 13 18:30:06 2012
  InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Release amd64 (20110427.1)
  ProcEnviron:
-  TERM=xterm
-  PATH=(custom, user)
-  LANG=en_US.UTF-8
-  SHELL=/bin/bash
+  TERM=xterm
+  PATH=(custom, user)
+  LANG=en_US.UTF-8
+  SHELL=/bin/bash
  SourcePackage: valgrind
  UpgradeStatus: Upgraded to precise on 2012-08-02 (11 days ago)

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to valgrind in Ubuntu.
https://bugs.launchpad.net/bugs/1036283

Title:
  callgrind_control cannot connect because of different executable name

Status in “valgrind” package in Ubuntu:
  Fix Released

Bug description:
  [Impact]
  When starting a Callgrind session using "valgrind", the actual executable name is "valgrind.bin". However, when callgrind_control searches for processes, its Perl regexp does not allow for this possibility. See callgrind_control line 32:
  Additionally the code contains several buffer overflows that can break depending on compiler optimizations.

  [TESTCASE]
    $ valgrind --tool=callgrind sleep 100 &
    $ callgrind_control -b
    No active callgrind runs detected.
  After making the change:
    $ valgrind --tool
    $ callgrind_control -b
    PID 23522: sleep 100

  [Regression Potential]
  the program currently doesn't work properly so there is little risk of things getting worse.
  The overflow fixes are applied upstream since several month and the process name fix is also in debian wheezy.

  
  ProblemType: Bug
  DistroRelease: Ubuntu 12.04
  Package: valgrind 1:3.7.0-0ubuntu3
  ProcVersionSignature: Ubuntu 3.2.0-27.43-generic 3.2.21
  Uname: Linux 3.2.0-27-generic x86_64
  NonfreeKernelModules: fglrx
  ApportVersion: 2.0.1-0ubuntu11
  Architecture: amd64
  Date: Mon Aug 13 18:30:06 2012
  InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Release amd64 (20110427.1)
  ProcEnviron:
   TERM=xterm
   PATH=(custom, user)
   LANG=en_US.UTF-8
   SHELL=/bin/bash
  SourcePackage: valgrind
  UpgradeStatus: Upgraded to precise on 2012-08-02 (11 days ago)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/valgrind/+bug/1036283/+subscriptions