[Bug 1003890] Re: unittest FAIL: test_pages_fit_on_a_netbook (test_gtkui.TestFrontend)

[Dmitrijs Ledkovs]

The gtk+ish way to deal with this probably is:
* use iconfactory
* add all icons as iconsets into a factory
* stop hardcoding /usr/share/pixmaps
* stop hardcoding ../pixmaps/
* fetch all icons/images using 'symbolic' names
* during testsuite set path / add path to the theme from source code or installed path

As a side-effect:
* ubiquity becomes fully themable, as in every single image can be replaced at runtime with a theme, which maybe desirable for respins.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubiquity in Ubuntu.
https://bugs.launchpad.net/bugs/1003890

Title:
  unittest FAIL: test_pages_fit_on_a_netbook (test_gtkui.TestFrontend)

Status in “ubiquity” package in Ubuntu:
  New

Bug description:
  $ cd ubiquity
  $ cd gui
  $ ln -s ../pixmaps & cd ../
  $ ./tests/run
  ======================================================================
  FAIL: test_pages_fit_on_a_netbook (test_gtkui.TestFrontend)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/home/tdlk/canonical/ubiquity/tests/test_gtkui.py", line 78, in test_pages_fit_on_a_netbook
      self.assertLessEqual(alloc.height, 500)
  AssertionError: 530 not less than or equal to 500

  ----------------------------------------------------------------------

  The problem is that .ui files are referencing relative paths for
  pixmaps which do not exist when run from unit-tests and during normal
  runs generate Gtk.Warnings similar to:

  (run:21508): Gtk-WARNING **: Could not load image
  '../pixmaps/cd_in_tray.png': Failed to open file
  'gui/gtk/../pixmaps/cd_in_tray.png': No such file or directory

  This does not happen with default_icon, because PIXMAPS environment
  variable is used to load the images.

  A while ago, there was a gtk api for search-dirs of e.g.
  images/content which I used in another project to source images both
  from the source tree & global/real install paths. need to look it up
  again.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1003890/+subscriptions