[Bug 894456] Re: Please merge or sync new btrfs-tools from Debian testing or unstable - lots of bugs present in Ubuntu now :(

Fri May 18 16:57:57 UTC 2012

That's only partly what I wanted to say. Here's a comparison of btrfsck
and e2fsck (different devices as I put btrfs on an SD card for this):

Case 1: FS mounted RW
e2fsck: sees that the FS is mounted and errors out as in your post.
$ sudo btrfsck /dev/mmcblk0p1 
/dev/mmcblk0p1 is currently mounted. Aborting.

Both abort as they should. OK

Case 2: FS unmounted
$ sudo e2fsck /dev/sdb1 
e2fsck 1.42 (29-Nov-2011)
/dev/sdb1: clean, 249/33200 files, 35453/132528 blocks
$ sudo btrfsck /dev/mmcblk0p1 
checking extents
checking fs roots
checking root refs
found 28672 bytes used err is 0
total csum bytes: 0
total tree bytes: 28672
total fs tree bytes: 8192
btree space waste bytes: 24411
file data blocks allocated: 0
 referenced 0
Btrfs Btrfs v0.19

Both do a simple check of the FS and return 0. OK

Case 3: FS mounted RO (this is the case on system bootup which we care about. mountall will call fsck -n <device> here)
$ sudo e2fsck -n /dev/sdb1 
e2fsck 1.42 (29-Nov-2011)
Warning!  /dev/sdb1 is mounted.
/dev/sdb1: clean, 249/33200 files, 35453/132528 blocks
$ sudo btrfsck -n /dev/mmcblk0p1 
/dev/mmcblk0p1 is currently mounted. Aborting.
-> exit status 240
-> mountall sees that fsck returned with non-zero exit status and you end up on the rescue prompt.
(that's the patched btrfsck from the package, otherwise it'll fail because it doesn't recognise -n)

So, that leaves us with an fsck.btrfs that's unusable for mountall purposes. I choose to symlink /bin/true, as that's a simple way to not re-introduce bug 660649. 
Solution 2 as I said would be a script that at least tells you that fsck.btrfs does nothing, and how you're supposed to use btrfsck.
Solution 3 would be to actually make -n do something useful, which would have to be done by the btrfsck developer. OR we adjust our btrfsck patch so it makes -n simply exit without doing anything.

Opinions?

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to btrfs-tools in Ubuntu.
https://bugs.launchpad.net/bugs/894456

Title:
  Please merge or sync new btrfs-tools from Debian testing or unstable -
  lots of bugs present in Ubuntu now :(

Status in “btrfs-tools” package in Ubuntu:
  Triaged
Status in Baltix GNU/Linux:
  New

Bug description:
  Curernt version of btrfs-tools in ubuntu 0.19+20100601 is very old and
  have lots of bugs comparing with the latest available from Debian
  testing or unstable:

  btrfs-tools (0.19+20111105-2) unstable; urgency=low

     * Using btrfs instead of btrfsctl in initramfs (Closes: #650614).

   -- Daniel Baumann <daniel.baumann at progress-technologies.net>  Sat, 10 Dec 2011 10:33:06 +0100
  btrfs-tools (0.19+20111105-1) unstable; urgency=low

     * Switching architecture fields to linux-any.
     * Adding patch to call gzip with full path when creating manpages to
       fix FTBFS on squeeze.
     * Using compression level 9 also for binary packages.
     * Merging upstream version 0.19+20111105.
     * Updating year in copyright file.
     * Sorting overrides in rules alphabetically.
     * Prefixing variables in rules to avoid clashes.
     * Rediffing labels.patch.
     * Rediffing ftbfs.patch.
     * Rediffing linker.patch.
     * Removing gcc-4.6.patch, not required anymore.
     * Renumbering patches.
     * Avoid polluting namespace by prefixing some tools with btrfs.
     * Updating list of additional tools to be built.

   -- Daniel Baumann <daniel.baumann at progress-technologies.net>  Sat, 19 Nov 2011 03:15:21 +0100
  btrfs-tools (0.19+20101101-2) unstable; urgency=low

     * Updating maintainer and uploaders fields.
     * Removing vcs fields.
     * Removing references to my old email address.
     * Updating year in copyright file.
     * Updating to standards version 3.9.2.
     * Compacting copyright file.
     * Dropping btrfs.modules, went into initramfs-tools (Closes: #612642).
     * Adding patch from Luk Claes <luk at debian.org> to fix FTBFS with --no-
       add-needed (Closes: #554059).
     * Adding patch from Jonathan Nieder <jrnieder at gmail.com> to fix FTBFS
       with gcc-4.6 (Closes: #616296).
     * Simplfying build and install overrides in rules.
     * Applying slightly modified patch from Jonathan Nieder
       <jrnieder at gmail.com> to fix CFLAGS handling in rules, see #616296.

   -- Daniel Baumann <daniel.baumann at progress-technologies.net>  Sun, 28 Aug 2011 09:31:25 +0200
  2010
  btrfs-tools (0.19+20101101-1) experimental; urgency=low

     * Merging upstream version 0.19+20101101.
     * Switching to source format 3.0 (quilt).

   -- Daniel Baumann <daniel.baumann at progress-technologies.net>  Sat, 20 Nov 2010 14:27:29 +0100
  btrfs-tools (0.19+20100909-2) experimental; urgency=low

     * Update references to btrfs-tools instead of btrfs-progs (upstream name)
       in manpages (Closes: #599111).
     * Removing warnings about experimental status.
     * Updating package to debhelper 8.

   -- Daniel Baumann <daniel.baumann at progress-technologies.net>  Mon, 04 Oct 2010 21:28:58 +0200
  btrfs-tools (0.19+20100909-1) experimental; urgency=low

     * Correcting credits for glibc.patch in patch file and changelog entry
       to David Sugar <david.sugar at canonical.com>.
     * Updating standards version to 3.9.0.
     * Merging upstream version 0.19+20100909.
     * Removing glibc.patch, merged upstream.
     * Updating standards version to 3.9.1.

   -- Daniel Baumann <daniel.baumann at progress-technologies.net>  Sat, 25
  Sep 2010 18:59:07 +0200

  Debian version is almost the latest from Chris Masson on
  git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git

  Please merge or sync new btrfs-tools from Debian testing or unstable

  Doing so might fix btrfsck reporting errors when dealing with a btrfs
  partition using compress=lzo.

  couldn't open because of unsupported option features (8).
  btrfsck: disk-io.c:679: open_ctree_fd: Assertion `!(1)' failed

  This is on Precise but also true for older Ubuntu versions

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/btrfs-tools/+bug/894456/+subscriptions