[Bug 931335] Re: Remove redundant code from resolvconf postinst
Launchpad Bug Tracker
931335 at bugs.launchpad.net
Mon May 14 20:45:16 UTC 2012
This bug was fixed in the package resolvconf - 1.65ubuntu4
---------------
resolvconf (1.65ubuntu4) quantal; urgency=low
* Also remove debian/triggers to avoid needlessly calling resolvconf's
postinst. (LP: #931335)
-- Stephane Graber <stgraber at ubuntu.com> Mon, 14 May 2012 16:40:55 -0400
** Changed in: resolvconf (Ubuntu)
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to resolvconf in Ubuntu.
https://bugs.launchpad.net/bugs/931335
Title:
Remove redundant code from resolvconf postinst
Status in “resolvconf” package in Ubuntu:
Fix Released
Bug description:
For earlier discussion please see #929552.
Resolvconf preinst has to create run-time directories. Resolvconf
postinst has to enable updates. (They of course do other things which
aren't relevant here.)
Resolvconf's Upstart job does both; /etc/init/resolvconf.conf contains
code like this:
[...]
start on mounted MOUNTPOINT=/run
pre-start script
mkdir -p /run/resolvconf/interface
touch /run/resolvconf/postponed-update
resolvconf --enable-updates
end script
[...]
Now, resolvconf postinst runs the Upstart job by means of
invoke-rc.d resolvconf start
where /etc/init.d/resolvconf is a symlink to /lib/init/upstart-job.
Because resolvconf postinst runs the upstart job which enables updates
it is not necessary for the postinst to enable updates itself.
Currently it does so by triggering itself and enabling updates when
"$1" = triggered. The section of the postinst that does this is
redundant and should be removed. See attachment for patch. The file
debian/triggers should also be removed.
(Background: In Debian, resolvconf.postinst triggers itself and only enables updates in the "triggered" phase; this avoid redundant update runs when resolvconf is installed along with packages whose postinsts induce resolvconf-updates.)
--
Thomas Hood
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/931335/+subscriptions
More information about the foundations-bugs
mailing list