[Bug 931335] Re: Remove redundant code from resolvconf postinst

[Thomas Hood]

Can you please apply the patch I contributed to the quantal version of
the package (currently 1.65ubuntu1)?

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to resolvconf in Ubuntu.
https://bugs.launchpad.net/bugs/931335

Title:
  Remove redundant code from resolvconf postinst

Status in “resolvconf” package in Ubuntu:
  Triaged

Bug description:
  For earlier discussion please see #929552.

  Resolvconf preinst has to create run-time directories.  Resolvconf
  postinst has to enable updates.  (They of course do other things which
  aren't relevant here.)

  Resolvconf's Upstart job does both; /etc/init/resolvconf.conf contains
  code like this:

      [...]
      start on mounted MOUNTPOINT=/run
      pre-start script
          mkdir -p /run/resolvconf/interface
          touch /run/resolvconf/postponed-update
          resolvconf --enable-updates
      end script
      [...]

  Now, resolvconf postinst runs the Upstart job by means of

      invoke-rc.d resolvconf start

  where /etc/init.d/resolvconf is a symlink to /lib/init/upstart-job.

  Because resolvconf postinst runs the upstart job which enables updates
  it is not necessary for the postinst to enable updates itself.
  Currently it does so by triggering itself and enabling updates when
  "$1" = triggered.  The section of the postinst that does this is
  redundant and should be removed.  See attachment for patch.  The file
  debian/triggers should also be removed.

  (Background: In Debian, resolvconf.postinst triggers itself and only enables updates in the "triggered" phase; this avoid redundant update runs when resolvconf is installed along with packages whose postinsts induce resolvconf-updates.)
  -- 
  Thomas Hood

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/931335/+subscriptions