[Bug 964940] [NEW] generator 90services-select fails if restricted and multiverse are both disabled

[Sgifford]

Public bug reported:

Debugging a problem with a preseeded custom installation of Ubuntu
Precise Pangolin, I saw this error report in my installation log:

  apt-setup: warning: /usr/lib/apt-setup/generators/90services-select
returned error code 1; discarding output

Troubleshooting the error, I found that it occurred when running
"disable_service partner".

The script runs with "-e" mode enabled, which causes it to immediately
exit if any command or function exits/returns nonzero.

The "disable_service" function returns nonzero if the service was not
actually removed, so when "disable_service partner" is run and "partner"
was not previously enabled, it returns nonzero, and the script aborts.

It looks like the return value from "disable_service" and
"enable_service" is not used anywhere, so the easiest fix would be to
simply never return nonzero from those functions.

** Affects: apt-setup (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apt-setup in Ubuntu.
https://bugs.launchpad.net/bugs/964940

Title:
  generator 90services-select fails if restricted and multiverse are
  both disabled

Status in “apt-setup” package in Ubuntu:
  New

Bug description:
  Debugging a problem with a preseeded custom installation of Ubuntu
  Precise Pangolin, I saw this error report in my installation log:

    apt-setup: warning: /usr/lib/apt-setup/generators/90services-select
  returned error code 1; discarding output

  Troubleshooting the error, I found that it occurred when running
  "disable_service partner".

  The script runs with "-e" mode enabled, which causes it to immediately
  exit if any command or function exits/returns nonzero.

  The "disable_service" function returns nonzero if the service was not
  actually removed, so when "disable_service partner" is run and
  "partner" was not previously enabled, it returns nonzero, and the
  script aborts.

  It looks like the return value from "disable_service" and
  "enable_service" is not used anywhere, so the easiest fix would be to
  simply never return nonzero from those functions.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-setup/+bug/964940/+subscriptions