[Bug 960079] Re: race condition in USR1 signal handling in mountall

[Ubuntu Foundation's Bug Bot]

The attachment "install the USR1 signal handler before daemonising" of
this bug report has been identified as being a patch.  The ubuntu-
reviewers team has been subscribed to the bug report so that they can
review the patch.  In the event that this is in fact not a patch you can
resolve this situation by removing the tag 'patch' from the bug report
and editing the attachment so that it is not flagged as a patch.
Additionally, if you are member of the ubuntu-reviewers team please also
unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by
Brian Murray.  Please contact him regarding any issues with the action
taken in this bug report.]

** Tags added: patch

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to mountall in Ubuntu.
https://bugs.launchpad.net/bugs/960079

Title:
  race condition in USR1 signal handling in mountall

Status in “mountall” package in Ubuntu:
  New

Bug description:
  There is a slight race condition in the way mountall installs its USR1
  signal handler. It does that after daemonising, so as a result the
  mountall-net job might send it the USR1 signal after the mountall job
  has reached the start/running state but before it has installed the
  signal handler.  This will result in mountall getting killed.

  Example of an automated test run showing this problem:
  http://hydra.nixos.org/build/2309161/log/raw.  The relevant line is:

  client2# [   10.963784] init: mountall main process (1971) killed by
  USR1 signal

  The attached patch (to mountall 2.35) fixes this by moving the
  installation of the USR1 handler to before the fork.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/mountall/+bug/960079/+subscriptions