[Bug 958551] Re: Crash while committing

[Martin Packman]

Thanks for the report, can you describe exactly how you supplied the
commit message, and was it partially populated from the debian
changelog? If so, can you attach the message you used?

This looks similar to bug 839426 and the underlying issue is related to
bug 663593, a byte string is getting through the commit builder and
breaking things a lower level.

** Changed in: bzr (Ubuntu)
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to bzr in Ubuntu.
https://bugs.launchpad.net/bugs/958551

Title:
  Crash while committing

Status in “bzr” package in Ubuntu:
  Incomplete

Bug description:
  I am using both the daily build (version
  2.5.0~bzr6511.6186~ppa4022~oneiric1) and the oneiric-proposed (version
  2.4.2-0ubuntu1), the crash happens (reproducible) with both versions.

  $ bzr commit --fixes lp:958534 --fixes lp:902339
  Committing to: /home/maarten/src/packaging/samba/samba/                                                                             
  modified .pc/applied-patches
  added .pc/documentation2.patch                                                                                                      
  ...and a lot more...
  modified examples/tridge/smb.conf
  modified swat/lang/tr/help/welcome.html
  bzr: ERROR: exceptions.UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 2431: ordinal not in range(128)         

  Traceback (most recent call last):
    File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 930, in exception_to_return_code
      return the_callable(*args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 1141, in run_bzr
      ret = run(*run_argv)
    File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 673, in run_argv_aliases
      return self.run(**all_cmd_args)
    File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 697, in run
      return self._operation.run_simple(*args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/bzrlib/cleanup.py", line 136, in run_simple
      self.cleanups, self.func, *args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/bzrlib/cleanup.py", line 166, in _do_with_cleanups
      result = func(*args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/bzrlib/builtins.py", line 3670, in run
      lossy=lossy)
    File "/usr/lib/python2.7/dist-packages/bzrlib/decorators.py", line 218, in write_locked
      result = unbound(self, *args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/bzrlib/workingtree_4.py", line 218, in commit
      result = WorkingTree.commit(self, message, revprops, *args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/bzrlib/decorators.py", line 218, in write_locked
      result = unbound(self, *args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/bzrlib/mutabletree.py", line 211, in commit
      *args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/bzrlib/commit.py", line 290, in commit
      lossy=lossy)
    File "/usr/lib/python2.7/dist-packages/bzrlib/cleanup.py", line 132, in run
      self.cleanups, self.func, self, *args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/bzrlib/cleanup.py", line 166, in _do_with_cleanups
      result = func(*args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/bzrlib/commit.py", line 447, in _commit
      self.rev_id = self.builder.commit(self.message)
    File "/usr/lib/python2.7/dist-packages/bzrlib/vf_repository.py", line 209, in commit
      self.repository._add_revision(rev)
    File "/usr/lib/python2.7/dist-packages/bzrlib/vf_repository.py", line 1068, in _add_revision
      text = self._serializer.write_revision_to_string(revision)
    File "/usr/lib/python2.7/dist-packages/bzrlib/chk_serializer.py", line 99, in write_revision_to_string
      ("message", encode_utf8(rev.message)[0]),
  UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 2431: ordinal not in range(128)

  The attachment contains the full crash report.

  I working directory that I cannot commit is made by:
   1) bzr branch lp:ubuntu/samba
   2) bzr branch lp:debian/samba samba-debian
   3) cd samba
   4) bzr merge ../samba-debian
   5) edit debian changelog
   6) bzr commit

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/958551/+subscriptions