[Bug 909919] Re: scripts/casper-bottom/41apt_cdrom is missing some sanity checking, can cause hang on boot

[cleary]

Revisiting this, it turns out it hangs due to the .disk/info file
missing, not README.diskdefines as I previously thought:

A more suitable patch might be:

--- scripts/casper-bottom/41apt_cdrom.orig	2011-12-30 09:38:20.033197874 +1100
+++ scripts/casper-bottom/41apt_cdrom	2011-12-30 09:43:53.733197834 +1100
@@ -18,6 +18,10 @@ esac
 
 . /scripts/casper-functions
 
+if [ ! -s /.disk/info]; then
+        exit 0
+fi
+
 mount -n -o bind /sys /root/sys
 mount -n -o bind /proc /root/proc
 mount -n -o bind /dev /root/dev

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to casper in Ubuntu.
https://bugs.launchpad.net/bugs/909919

Title:
  scripts/casper-bottom/41apt_cdrom is missing some sanity checking, can
  cause hang on boot

Status in “casper” package in Ubuntu:
  Confirmed

Bug description:
  Distribution Release: 12.04 Precise
  Casper: 1.296

  in scripts/casper-bottom/41apt_cdrom, if an apt repository is not configured in the root of the LiveCD, the script hangs the boot process waiting for input with the message:
  "Please provide a name for this Disc, such as 'Debian 5.0.3 Disk 1"

  Some sort of checking is needed here to see if the conditions required for the apt-cdrom repository are fulfilled, and to fail silently if they are not - I've attached a possible patch:
   * if /README.diskdefines does not exist in the root of the CDROM, exit with no error

   having said that I'm not certain of the role of the
  README.diskdefines file, so it may not be the best choice for
  checking.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/casper/+bug/909919/+subscriptions