[Bug 1026257] Re: UpdateManager.backend.InstallBackend() incompatible API change

[Brian Murray]

** Changed in: update-manager (Ubuntu)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-manager in Ubuntu.
https://bugs.launchpad.net/bugs/1026257

Title:
  UpdateManager.backend.InstallBackend() incompatible API change

Status in “update-manager” package in Ubuntu:
  New

Bug description:
  InstallBackend.__init__() changed incompatibly to add a `datadir`
  argument *before* the window_main argument.  This breaks apturl (see
  LP: #1020980) and who knows what else.

  The way the change *should* have been made is to add `datadir=None`
  after the window_main argument.  That way, subclasses which don't have
  a datadir would have continued to work.

  I'm not sure whether this is worth fixing now, but we need to be much
  more careful in the future about incompatible API changes.  This is
  the revision where the change was made:

  
  % bzr log -v -c 2428.3.1
  ------------------------------------------------------------
  revno: 2428.3.1
  committer: Michael Terry <michael.terry at canonical.com>
  branch nick: progress-dialog
  timestamp: Wed 2012-06-13 15:47:47 -0400
  message:
    bring some of AptDialog from aptdaemon into our code to have more control over its presentation (i.e. stuff the widgets inside of our own main window; split UpdateManager into a central point of control and put old widgets into UpdatesAvailable class
  added:
    UpdateManager/InstallProgress.py
    UpdateManager/UpdateManager.py
    data/gtkbuilder/UpdateProgress.ui
  renamed:
    UpdateManager/UpdateManager.py => UpdateManager/UpdatesAvailable.py
  modified:
    UpdateManager/UpdateProgress.py
    UpdateManager/backend/InstallBackendAptdaemon.py
    UpdateManager/backend/__init__.py
    data/gtkbuilder/UpdateManager.ui
    update-manager
    UpdateManager/UpdatesAvailable.py

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/1026257/+subscriptions