[Bug 923407] Re: pkgstripfiles: md5sum incorrect when advpng fails

[Martin Pitt]

Thanks! Indeed they should both be removed, there is no reason that
advpng should be skipped if optipng fails.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to pkgbinarymangler in Ubuntu.
https://bugs.launchpad.net/bugs/923407

Title:
  pkgstripfiles: md5sum incorrect when advpng fails

Status in “pkgbinarymangler” package in Ubuntu:
  Fix Committed

Bug description:
  The md5sum is not updated when advpng fails but optipng ran fine.

  This happened with the gquilt 0.25-2 package:
  Unexpected PLTE chunk on ./usr/share/pixmaps/gquilt/stock_finish.png [at void throw_png_error():pngex.h:37]
  WARNING: advpng failed on ./usr/share/pixmaps/gquilt/stock_finish.png, ignoring

  Then lintian says:
  E: gquilt: md5sum-mismatch usr/share/pixmaps/gquilt/stock_finish.png

  
  >	if ! optipng -o4 -preserve "$f"; then
  >	    echo "WARNING: optipng failed on $f, ignoring" >&2
  >	    continue
  >	fi
  >	if ! advpng -z4 "$f"; then
  >	    echo "WARNING: advpng failed on $f, ignoring" >&2
  >	    continue
  >	fi

  The second continue statement needs to be removed.
  I'm not sure why the first one is there, mabye both should be removed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pkgbinarymangler/+bug/923407/+subscriptions