[Bug 913085] Re: Translation domain detection from config.h is broken

[Gabor Kelemen]

Thanks for the quick fix. I still see these:

$ grep Domain=\" /usr/share/applications/*
/usr/share/applications/evolution.desktop:X-Ubuntu-Gettext-Domain="evolution-3.2"
/usr/share/applications/evolution-settings.desktop:X-Ubuntu-Gettext-Domain="evolution-3.2"
/usr/share/applications/gnome-contacts.desktop:X-Ubuntu-Gettext-Domain="gnome-contacts"
/usr/share/applications/gnome-panel.desktop:X-Ubuntu-Gettext-Domain="gnome-panel-3.0"
/usr/share/applications/gnome-shell.desktop:X-Ubuntu-Gettext-Domain="gnome-shell"
/usr/share/applications/palimpsest.desktop:X-Ubuntu-Gettext-Domain="gnome-disk-utility"
/usr/share/applications/rhythmbox.desktop:X-Ubuntu-Gettext-Domain="rhythmbox"
/usr/share/applications/rhythmbox-device.desktop:X-Ubuntu-Gettext-Domain="rhythmbox"

But I think it is safe to not hurry - there can be some unrelated
uploads in the coming days which will fix these, like there were today
in case of empathy or nautilus.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to pkgbinarymangler in Ubuntu.
https://bugs.launchpad.net/bugs/913085

Title:
  Translation domain detection from config.h is broken

Status in “gnome-control-center” package in Ubuntu:
  Triaged
Status in “gnome-media” package in Ubuntu:
  Triaged
Status in “gnome-settings-daemon” package in Ubuntu:
  Triaged
Status in “pkgbinarymangler” package in Ubuntu:
  Fix Released
Status in “totem” package in Ubuntu:
  Triaged

Bug description:
  Latest package version 111 added support for detecting the translation
  domain from config.h:

  http://bazaar.launchpad.net/~ubuntu-
  branches/ubuntu/precise/pkgbinarymangler/precise/revision/231#dh_translations

  This is however a little broken: the domain is in a quoted form in
  those files and dh_translations retains the quotation marks instead of
  ignoring them. I see for example

  #define GETTEXT_PACKAGE "gparted"

  resulting this:

  dh_translations
  	check_buildsystem: got domain '"gparted"', using intltool: 1
  	/usr/bin/intltool-update -p --verbose -g \"gparted\"
  Wrote ../data/com.ubuntu.pkexec.gparted.policy.in.h
  Wrote ../gparted.desktop.in.in.h
  Building "gparted".pot...
  Running xgettext --add-comments --directory=. --default-domain="gparted" --flag=g_strdup_printf:1:c-format --flag=g_string_printf:2:c-format --flag=g_string_append_printf:2:c-format --flag=g_error_new:3:c-format --flag=g_set_error:4:c-format --flag=g_markup_printf_escaped:1:c-format --flag=g_log:3:c-format --flag=g_print:1:c-format --flag=g_printerr:1:c-format --flag=g_printf:1:c-format --flag=g_fprintf:2:c-format --flag=g_sprintf:2:c-format --flag=g_snprintf:3:c-format --flag=g_scanner_error:2:c-format --flag=g_scanner_warn:2:c-format --output="gparted".pot --files-from=./POTFILES.in.temp --keyword=_ --keyword=N_ --keyword=C_:1c,2 --keyword=NC_:1c,2 --keyword=Q_ --keyword=g_dgettext:2 --keyword=g_dngettext:2,3 --keyword=g_dpgettext:2 --keyword=g_dpgettext2=2c,3 --from-code=UTF-8
  Removing generated header (.h) files...done.
  None of the files in POTFILES.in contain strings marked for translation.
  make[1]: Entering directory `/home/gabor/checkout/ubuntu/build-area/gparted-0.8.1/help'
  `which xml2po` -e -o gparted.pot C/gparted.xml
  make[1]: Leaving directory `/home/gabor/checkout/ubuntu/build-area/gparted-0.8.1/help'
  dh_langpack: processing files to add translation domain '"gparted"'...

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/913085/+subscriptions