[Bug 936835] [NEW] Resolvconf error condition on enable/disable update should reflect success of just that

[Thomas Hood]

Public bug reported:

For background see #933566.

When Upstart attempts to start a job and the pre-start script returns an
error, Upstart will consider the job not to have been started.

Because resolvconf is treated as an Upstart job, resolvconf updates
being enabled/disable should correspond to resolvconf Upstart job being
"started"/"stopped".

So the resolvconf job pre-start script should return an error when and
only when updates could not be enabled.

Making this so requires that resolvconf (1.63ubuntu7) be patched as
follows.

$ diff -u resolvconf_ORIG resolvconf
--- resolvconf_ORIG	2012-02-19 16:49:46.725254960 +0100
+++ resolvconf	2012-02-19 16:51:39.277257572 +0100
@@ -113,9 +113,9 @@
  fi
  ;;
   --enable-updates)
-	: >| "$ENABLE_UPDATES_FLAGFILE"
+	: >| "$ENABLE_UPDATES_FLAGFILE" || exit 1
  if [ -e "$POSTPONED_UPDATE_FLAGFILE" ] ; then
-	 update_and_exit -u
+	 (update_and_exit -u) || :
  fi
  exit 0
  ;;

** Affects: resolvconf (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to resolvconf in Ubuntu.
https://bugs.launchpad.net/bugs/936835

Title:
  Resolvconf error condition on enable/disable update should reflect
  success of just that

Status in “resolvconf” package in Ubuntu:
  New

Bug description:
  For background see #933566.

  When Upstart attempts to start a job and the pre-start script returns
  an error, Upstart will consider the job not to have been started.

  Because resolvconf is treated as an Upstart job, resolvconf updates
  being enabled/disable should correspond to resolvconf Upstart job
  being "started"/"stopped".

  So the resolvconf job pre-start script should return an error when and
  only when updates could not be enabled.

  Making this so requires that resolvconf (1.63ubuntu7) be patched as
  follows.

  $ diff -u resolvconf_ORIG resolvconf
  --- resolvconf_ORIG	2012-02-19 16:49:46.725254960 +0100
  +++ resolvconf	2012-02-19 16:51:39.277257572 +0100
  @@ -113,9 +113,9 @@
    fi
    ;;
     --enable-updates)
  -	: >| "$ENABLE_UPDATES_FLAGFILE"
  +	: >| "$ENABLE_UPDATES_FLAGFILE" || exit 1
    if [ -e "$POSTPONED_UPDATE_FLAGFILE" ] ; then
  -	 update_and_exit -u
  +	 (update_and_exit -u) || :
    fi
    exit 0
    ;;

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/936835/+subscriptions