[Bug 933566] Re: Stopping resolvconf doesn't disable updates

[Thomas Hood]

Steve Langasek wrote:
> Conceptually, I think there's no reason not to use
> post-stop since the post-stop script is run before
> the stopped event is emitted, so I'll go ahead with
> committing this fix [...]


Using post-stop has the consequence that any error during the resolvconf update run in the upstart job causes resolvconf updates to be disabled.  That is undesirable IMHO.  Using pre-stop does not have this consequence.  

But we can't use pre-stop until Upstart is changed so that it actually
runs pre-stop.  Ideally we'd just fix Upstart and not change the
resolvconf Upstart job definition.  How fast can we get Upstart fixed?

If we can't get Upstart fixed in an acceptable time frame then I'd
propose a different workaround.  Create a resolvconf-stop Upstart job
that *starts* on runlevel [06] and that disables updates in its pre-
start.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to upstart in Ubuntu.
https://bugs.launchpad.net/bugs/933566

Title:
  Stopping resolvconf doesn't disable updates

Status in “resolvconf” package in Ubuntu:
  Fix Committed
Status in “upstart” package in Ubuntu:
  New

Bug description:
  Stopping the resolvconf job should disable updates by means of
  deleting the enable-updates flag file, but this does not happen.

  # ls -l /run/resolvconf
  total 4
  -rw-r--r-- 1 root root   0 2012-02-16 17:02 enable-updates
  drwxr-xr-x 2 root root  60 2012-02-16 17:02 interface
  -rw-r--r-- 1 root root 177 2012-02-16 17:02 resolv.conf
  # stop resolvconf
  stop: Unknown instance: 
  # ls -l /run/resolvconf
  total 4
  -rw-r--r-- 1 root root   0 2012-02-16 17:02 enable-updates
  drwxr-xr-x 2 root root  60 2012-02-16 17:02 interface
  -rw-r--r-- 1 root root 177 2012-02-16 17:02 resolv.conf
  # start resolvconf 
  resolvconf start/running
  # stop resolvconf
  resolvconf stop/waiting
  # ls -l /run/resolvconf
  total 4
  -rw-r--r-- 1 root root   0 2012-02-16 17:06 enable-updates
  drwxr-xr-x 2 root root  60 2012-02-16 17:02 interface
  -rw-r--r-- 1 root root 177 2012-02-16 17:02 resolv.conf

  
  The following change seems to fix this.

  
  --- /etc/init/resolvconf.conf_ORIG	2012-02-16 17:09:22.313489458 +0100
  +++ /etc/init/resolvconf.conf	2012-02-16 17:08:31.398957282 +0100
  @@ -14,6 +14,6 @@
   	resolvconf --enable-updates
   end script
   
  -pre-stop script
  +post-stop script
   	resolvconf --disable-updates
   end script

  
  # stop resolvconf
  resolvconf stop/waiting
  # ls -l /run/resolvconf
  total 4
  drwxr-xr-x 2 root root  60 2012-02-16 17:02 interface
  -rw-r--r-- 1 root root 177 2012-02-16 17:02 resolv.conf

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/933566/+subscriptions