[Bug 933566] Re: Stopping resolvconf doesn't disable updates

[Steve Langasek]

> But don't make that change, because then updates are not enabled after
> reboot!

Well, it looks like the change may be per se correct, and you simply have
something amiss on your system that's causing the resolvconf job to fail at
startup.  It doesn't fail for me.

> it looks to me as if resolvconf is both started and stopped on boot,
> except that pre-stop scripts are not run.  Or something.  I don't
> understand Upstart.

This looks to me like a previously unreported bug in upstart.
resolvconf is the only job on my system which tries to use pre-start +
pre-stop without a main process.  Conceptually, I think there's no
reason not to use post-stop since the post-stop script is run before the
stopped event is emitted, so I'll go ahead with committing this fix (but
not uploading until we know why resolvconf is failing to start for you
on boot).

Also raising a task on upstart, since I don't think the pre-stop script
should be silently skipped here.

** Changed in: resolvconf (Ubuntu)
       Status: New => Triaged

** Changed in: resolvconf (Ubuntu)
   Importance: Undecided => High

** Also affects: upstart (Ubuntu)
   Importance: Undecided
       Status: New

** Changed in: upstart (Ubuntu)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to upstart in Ubuntu.
https://bugs.launchpad.net/bugs/933566

Title:
  Stopping resolvconf doesn't disable updates

Status in “resolvconf” package in Ubuntu:
  Triaged
Status in “upstart” package in Ubuntu:
  New

Bug description:
  Stopping the resolvconf job should disable updates by means of
  deleting the enable-updates flag file, but this does not happen.

  # ls -l /run/resolvconf
  total 4
  -rw-r--r-- 1 root root   0 2012-02-16 17:02 enable-updates
  drwxr-xr-x 2 root root  60 2012-02-16 17:02 interface
  -rw-r--r-- 1 root root 177 2012-02-16 17:02 resolv.conf
  # stop resolvconf
  stop: Unknown instance: 
  # ls -l /run/resolvconf
  total 4
  -rw-r--r-- 1 root root   0 2012-02-16 17:02 enable-updates
  drwxr-xr-x 2 root root  60 2012-02-16 17:02 interface
  -rw-r--r-- 1 root root 177 2012-02-16 17:02 resolv.conf
  # start resolvconf 
  resolvconf start/running
  # stop resolvconf
  resolvconf stop/waiting
  # ls -l /run/resolvconf
  total 4
  -rw-r--r-- 1 root root   0 2012-02-16 17:06 enable-updates
  drwxr-xr-x 2 root root  60 2012-02-16 17:02 interface
  -rw-r--r-- 1 root root 177 2012-02-16 17:02 resolv.conf

  
  The following change seems to fix this.

  
  --- /etc/init/resolvconf.conf_ORIG	2012-02-16 17:09:22.313489458 +0100
  +++ /etc/init/resolvconf.conf	2012-02-16 17:08:31.398957282 +0100
  @@ -14,6 +14,6 @@
   	resolvconf --enable-updates
   end script
   
  -pre-stop script
  +post-stop script
   	resolvconf --disable-updates
   end script

  
  # stop resolvconf
  resolvconf stop/waiting
  # ls -l /run/resolvconf
  total 4
  drwxr-xr-x 2 root root  60 2012-02-16 17:02 interface
  -rw-r--r-- 1 root root 177 2012-02-16 17:02 resolv.conf

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/933566/+subscriptions