[Bug 931220] Re: lxc.conf upstart job fails to spawn containers at boot time

[Stéphane Graber]

Assigning to Serge at his request ;)

The issue was tracked down to be an inherited fd likely from libldap
passed to libnss-ldap then passed to libnss and eventually to upstart.
This socket isn't marked as CLOEXEC so all processes inherit it.

I'll file a separate bug against upstart to have all the fds closed
before running the jobs, for now though we think it'd be good to have a
close-all-fds option in lxc, possibly making it the default for -d so we
can use it to workaround these issues.

** Changed in: upstart (Ubuntu)
       Status: New => Invalid

** Changed in: lxc (Ubuntu)
       Status: New => Triaged

** Changed in: lxc (Ubuntu)
     Assignee: (unassigned) => Serge Hallyn (serge-hallyn)

** Summary changed:

- lxc.conf upstart job fails to spawn containers at boot time
+ lxc-start should get a close-all-fds option to avoid weird issues

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to upstart in Ubuntu.
https://bugs.launchpad.net/bugs/931220

Title:
  lxc-start should get a close-all-fds option to avoid weird issues

Status in “lxc” package in Ubuntu:
  Triaged
Status in “upstart” package in Ubuntu:
  Invalid

Bug description:
  root at vorash:~# cat /var/log/upstart/lxc.log 
  + [ -f /etc/default/lxc ]
  + . /etc/default/lxc
  + LXC_AUTO=true
  + USE_LXC_BRIDGE=false
  + LXC_BRIDGE=lxcbr0
  + LXC_ADDR=10.0.3.1
  + LXC_NETMASK=255.255.255.0
  + LXC_NETWORK=10.0.3.0/24
  + LXC_DHCP_RANGE=10.0.3.2,10.0.3.254
  + LXC_DHCP_MAX=253
  + [ xtrue = xtrue ]
  + ls /etc/lxc/auto/v6test01.conf
  + basename /etc/lxc/auto/v6test01.conf .conf
  + c=v6test01
  + lxc-info -n v6test01
  + grep state
  + grep -q RUNNING
  + lxc-start -l debug -o /run/debug -n v6test01 -f /etc/lxc/auto/v6test01.conf -d

  root at vorash:~# cat /run/debug 
        lxc-start 1329097397.477 ERROR    lxc_start - inherited fd 21 on socket:[17416]

  
  The first listing is the output of lxc.conf running with "set -x" and upstart logging with an added "-l debug -o /run/debug" to the lxc-start command line.
  The second is the output in /run/debug

  Apparently lxc-start is inheriting an fd from upstart causing lxc to
  fail to start.

  I'm marking this high against lxc and also adding an upstart task in
  case we're inheriting this fd from some upstart issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/931220/+subscriptions