[Bug 923407] Re: pkgstripfiles: md5sum incorrect when advpng fails

[Launchpad Bug Tracker]

This bug was fixed in the package pkgbinarymangler - 114

---------------
pkgbinarymangler (114) precise; urgency=low

  [ Felix Geyer ]
  * pkgstripfiles, symlink_doc(): Don't create symlinks that would point to
    the same package. (LP: #923343)
  * test/run: Add test_doc_symlink_dependency_cycle() to make sure that
    pkgstripfiles works correctly when there is a dependency cycle inside
    a source package.

  [ Martin Pitt ]
  * pkgstripfiles: Always update md5sum even if advpng fails. Also call advpng
    if optipng fails, to at least get some optimization. Thanks Felix Geyer!
    (LP: #923407)
  * pkgstripfiles: Do not truncate changelogs when they are in a different
    directory pointed to a symlink. Add corresponding test case which mimics
    the perl hack that it applies to its doc files. (LP: #923430)
 -- Martin Pitt <martin.pitt at ubuntu.com>   Fri, 03 Feb 2012 06:36:35 +0100

** Changed in: pkgbinarymangler (Ubuntu)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to pkgbinarymangler in Ubuntu.
https://bugs.launchpad.net/bugs/923407

Title:
  pkgstripfiles: md5sum incorrect when advpng fails

Status in “pkgbinarymangler” package in Ubuntu:
  Fix Released

Bug description:
  The md5sum is not updated when advpng fails but optipng ran fine.

  This happened with the gquilt 0.25-2 package:
  Unexpected PLTE chunk on ./usr/share/pixmaps/gquilt/stock_finish.png [at void throw_png_error():pngex.h:37]
  WARNING: advpng failed on ./usr/share/pixmaps/gquilt/stock_finish.png, ignoring

  Then lintian says:
  E: gquilt: md5sum-mismatch usr/share/pixmaps/gquilt/stock_finish.png

  
  >	if ! optipng -o4 -preserve "$f"; then
  >	    echo "WARNING: optipng failed on $f, ignoring" >&2
  >	    continue
  >	fi
  >	if ! advpng -z4 "$f"; then
  >	    echo "WARNING: advpng failed on $f, ignoring" >&2
  >	    continue
  >	fi

  The second continue statement needs to be removed.
  I'm not sure why the first one is there, mabye both should be removed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pkgbinarymangler/+bug/923407/+subscriptions