[Bug 610820] Re: Download size discrepancies

[Martin Pitt]

Accepted python-apt into natty-proposed, the package will build now and
be available in a few hours. Please test and give feedback here. See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed. Thank you in advance!

** Changed in: python-apt (Ubuntu Natty)
       Status: Triaged => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to python-apt in Ubuntu.
https://bugs.launchpad.net/bugs/610820

Title:
  Download size discrepancies

Status in Update Manager:
  Invalid
Status in “python-apt” package in Ubuntu:
  Fix Released
Status in “python-apt” source package in Maverick:
  Fix Committed
Status in “python-apt” source package in Natty:
  Fix Committed

Bug description:
  python-apt returns incorrect values for some API functions on ARM due
  to broken signed/unsigned and long/int integer conversions.

  Impact:
  bogus values (e.g. read from stack) for some function calls such as size of a package in cache; this causes user visible issues such as update-manager download sizes, or breaks linaro-image-tools when creating Linaro images (maverick host)

  Fix:
  This was fixed by using MkPyNumber(...) instead of Py_BuildValue("i", ...) or Py_BuildValue("k", ...)

  TEST CASE:
  run lp610820.py attached to this bug; if the output is a single entry in the size -> number of packages in cache hash, then python-apt is broken:
          0 => 33936

  instead, it should look like a long distribution of values in the form of:
        922 =>     4
       1798 =>     6
       1800 =>     4
       1802 =>     5
       1828 =>     6
       1830 =>    10
       1832 =>     7

  Regression potential:
  Could break the patches functions or could regress applications which relied on the bogus behavior; the builtin testsuite which is run during package build will help a bit with catching the first class of issues, and we'd likely want to fix the other issues by themselves.  Testsuite coverage is likely not 100% perfect though