[Bug 874774] Re: could not mount /dev/mapper/cryptswap1

[Steve Langasek]

elif [ -n "$DEVLINKS" ]; then
                        for link in $DEVLINKS; do
                                if [ "x$link" != "x$src" ]; then
                                        continue
                                fi
                                break 2
                        done

I'm still having trouble with this as I'm reading it :)  Maybe my brain
is just not in shell mode today, but I believe what we need to have
happen here is:

 - if $src matches one of the links in $DEVLINKS, we have a match and should mount this device.
 - if $src matches none of the links in $DEVLINKS, and also doesn't match $1, skip this line and look for another match in crypttab.

The current patch appears to have the following wrong properties:
 - if $DEVLINKS is set but the crypttab line matches the device name instead of one of the links, it will not be processed correctly (because we never get a chance to compare $1 and $src)
 - if $src matches none of the links in $DEVLINKS, we'll hit the 'continue' each time through the for loop, so the break will never be hit and we'll (incorrectly) try to process the line
 - if $src *does* match one of the links in $DEVLINKS, we will hit the 'break 2' and *not* process *any* more lines in crypttab.

So I think your patch usually works, but only as a side effect.  I'll
take a crack at the patch here.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to cryptsetup in Ubuntu.
https://bugs.launchpad.net/bugs/874774

Title:
  could not mount /dev/mapper/cryptswap1

Status in “cryptsetup” package in Ubuntu:
  Triaged
Status in “cryptsetup” source package in Oneiric:
  Triaged
Status in “cryptsetup” source package in Precise:
  Triaged

Bug description:
  On multiple fresh installs since beta release 2 i have been experiencing this issue:
  during boot up, i receive the message "could not mount /dev/mapper/cryptswap1 M for manual S for skip"
  obviously I'm expecting no message to show up at all and it should boot perfectly fine. I do however believe that i have found where the problem lies, it is in /etc/fstab
  This is how the original file looked:

  # /etc/fstab: static file system information.
  #
  # Use 'blkid' to print the universally unique identifier for a
  # device; this may be used with UUID= as a more robust way to name devices
  # that works even if disks are added and removed. See fstab(5).
  #
  # <file system> <mount point>   <type>  <options>       <dump>  <pass>
  proc            /proc           proc    nodev,noexec,nosuid 0       0
  # / was on /dev/sda7 during installation
  UUID=482c5b33-9ce8-4575-b787-cddeb1e93a5e /               ext4    errors=remount-ro 0       1
  # swap was on /dev/sda8 during installation
  #UUID=eb23dadc-8e08-4769-8fc5-0b1216b67e5b none            swap    sw              0       0
  /dev/mapper/cryptswap1 none swap sw 0 0

  
  i believe the problem is that the following line of:
  #UUID=eb23dadc-8e08-4769-8fc5-0b1216b67e5b none            swap    sw              0       0

  is not supposed to be commented out, i believe this happens somewhere
  in install. The ghetto fix for this is simply to remove the comment on
  it, but it definitely should not be happening...

  i have also found a eerily similar problem from Ubuntu 9.10 Bug
  #490760  which is a "duplicate" of another bug that is why i
  classified this as cryptsetup, because that bug was.

  Here is more information:

  Description:	Ubuntu 11.10
  Release:	11.10

  cryptsetup:
    Installed: 2:1.1.3-4ubuntu2
    Candidate: 2:1.1.3-4ubuntu2
    Version table:
   *** 2:1.1.3-4ubuntu2 0
          500 http://us.archive.ubuntu.com/ubuntu/ oneiric/main amd64 Packages
          100 /var/lib/dpkg/status

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/874774/+subscriptions