[Bug 90328] file-roller leaves gigantic hidden files on disk when it fails due to lack of disk space

[Jason Spiro]

Public bug reported:

Binary package hint: file-roller

== Steps to reproduce ==

1. Open File Roller
2. Create a new .tar.gz file on an almost-full disk (If you have a USB flash disk that is almost full, that will work fine.)
3. Add so many files to it that it will take up all free space on your disk

== What happens ==

1. You get an error message[1]
2. A huge partially-complete .tar.gz file is left on your disk (in my case, I had a few 100MB+ files lying around in various places on my hard drive, as it is often nearly-full yet I often take new backups of my USB drive.)
3. **Big problem**: this .tar.gz file is a hidden dotfile

== What should have happened ==

File Roller should never leave dotfiles on disk after you close it, no
matter what errors it encountered.

== Proposed solution ==

File Roller should never name its temporary files starting with a
period.  Instead, it should name them something like
temporary_archive_6313.  Yes, it looks somewhat ugly when these files
are visible to users, and yes, there are other possible solutions.  But
all other solutions are either slower or can leave dotfiles around in
pathological cases.  This is the only way to prevent File Roller from
leaving orphaned dotfiles around.

== Notes ==

I am using file-roller 2.16.1 which came with Edgy.

[1] Here is the error text I got:
tar: /home/j/.fr.6313.0.jason_backup.tar: Cannot write: No space left on device
tar: Error is not recoverable: exiting now
gzip: /home/j/.fr.6313.0.jason_backup.tar.gz: Cannot write: No space left on device
mv: cannot stat home/j/.fr.6313.0.jason_backup.tar.gz:: Aucun fichier ou repertoire de ce type (note to readers: this means "No such file or directory")

** Affects: fileroller (upstream)
     Importance: Unknown
         Status: Unknown
** Affects: file-roller (Ubuntu)
     Importance: Medium
     Assignee: Ubuntu Desktop Bugs
         Status: Confirmed

-- 
file-roller leaves gigantic hidden files on disk when it fails due to lack of disk space
https://launchpad.net/bugs/90328