[Bug 59342] Re: hal don't find that I'm on a laptop

Martin Pitt martin.pitt at ubuntu.com
Tue Sep 12 08:48:04 UTC 2006

For the record:

<pitti> curious - the place you patched out of osspec.c already tries to not overwrite the value with 'unknown'
<pitti> this almost looks as if the inner if should be fixed
<pitti>                                 if (strcmp (hal_device_property_get_string (d, "system.formfactor"), "unknown"))
<pitti> -> to !strcmp
<pitti> and an alternative added, for the case if the property does not exist yet
<pitti> anyway, I'm applying your patch for now, but can you please take another look at this?
<pitti> it should be something like
<pitti> if (!hal_device_property_exists(formfactor) || !strcmp(h_d_p_get_string(formfactor), "unknown") { overwrite formfactor };

** Changed in: hal (Ubuntu)
       Status: In Progress => Fix Committed

hal don't find that I'm on a laptop

More information about the desktop-bugs mailing list