<html> <head> <meta content="text/html; charset=utf-8" http-equiv="Content-Type"> </head> <body text="#000000" bgcolor="#FFFFFF"> <div class="moz-cite-prefix">On 2015-11-29 09:56, Matthew D. Fuller wrote: </div> <blockquote cite="mid:20151129085602.GY30248@over-yonder.net" type="cite"> <pre wrap="">On Sun, Nov 29, 2015 at 09:53:33AM +0100 I heard the voice of Sebastien Alaiwan, and lo! it spake thus: </pre> <blockquote type="cite"> <pre wrap=""> Is this the expected behaviour? Not updating the "revno" file on "bzr update -r XXX" commands seems error-prone, as you might want to build older revisions of your project. I was about to suggest to directly use, from your build system, the ".bzr/branch/last-revision" file. However, this will couple your build system to bazaar ; which you probably want to avoid. </pre> </blockquote> <pre wrap=""> Technically, you'd want to be directly using .bzr/checkout/dirstate, since you care about the WT rev, not the branch rev. </pre> </blockquote> Thanks for your suggestion. Then, I'd better go for the plugin approach than trying to parse 'dirstate' with a one-liner in a build system. Here's a modified version of Chris' plugin. I managed to catch the event "bzr update -r some_old_revision", however, it seems I catch it too early: at this point, the revno is still the "old" revision number of the tree. I mean, the revno which gets printed is the one before the application of the "bzr update" command. I searched through the documentation, but I can't find an event related to the MutableTree occuring "at the end" of a "bzr update" command. Any ideas? (Disclaimer: I need to achieve the same behaviour for fixing bzr-externals.) <tt>"""Update the "revno" file when the branch changes.</tt><tt> </tt><tt> </tt><tt>This post_change_branch_tip hook puts the current revno in a file called</tt><tt> </tt><tt>"revno" in the base directory of the current branch, if it exists. If "revno"</tt><tt> </tt><tt>doesn't exist, then it is not created."""</tt><tt> </tt><tt> </tt><tt>from bzrlib import branch, mutabletree</tt><tt> </tt><tt>version_info = (1, 0, 0, 'final', 0)</tt><tt> </tt><tt> </tt><tt>def write_revno_file(branch, revno, revid):</tt><tt> </tt><tt> import os.path</tt><tt> </tt><tt> from bzrlib import errors</tt><tt> </tt><tt> print "write_revno_file: ", revno</tt><tt> </tt><tt> try:</tt><tt> </tt><tt> trans = branch.bzrdir.root_transport</tt><tt> </tt><tt> path = trans.local_abspath('revno')</tt><tt> </tt><tt> except errors.NotLocalUrl:</tt><tt> </tt><tt> return # Nothing to do for a remote URL</tt><tt> </tt><tt> if os.path.isfile(path):</tt><tt> </tt><tt> f = open(path,'w')</tt><tt> </tt><tt> f.write('%s\n%s' % (revno, revid))</tt><tt> </tt><tt> f.close()</tt><tt> </tt><tt> </tt><tt>def update_revno_file_on_bzrcommit(params):</tt><tt> </tt><tt> print "update_revno_file_on_bzrcommit"</tt><tt> </tt><tt> write_revno_file(params.branch, params.new_revno, params.new_revid)</tt><tt> </tt><tt> </tt><tt>branch.Branch.hooks.install_named_hook('post_change_branch_tip',</tt><tt> </tt><tt> update_revno_file_on_bzrcommit,</tt><tt> </tt><tt> 'N/A')</tt><tt> </tt> <tt>def update_revno_file_on_bzrupdate(tree, transform):</tt><tt> </tt><tt> print "update_revno_file_on_bzrupdate"</tt><tt> </tt><tt> revid = tree.last_revision()</tt><tt> </tt><tt> revno_t = tree.branch.revision_id_to_dotted_revno(revid)</tt><tt> </tt><tt> revno = ".".join(str(n) for n in revno_t)</tt><tt> </tt><tt> write_revno_file(tree.branch, revno, revid)</tt><tt> </tt><tt> </tt><tt>mutabletree.MutableTree.hooks.install_named_hook('post_transform',</tt><tt> </tt><tt> update_revno_file_on_bzrupdate,</tt><tt> </tt><tt> 'N/A')</tt><tt> </tt><tt> </tt> </body> </html>