<div class="gmail_quote">On Wed, Nov 4, 2009 at 9:49 PM, John Arbash Meinel <<a href="mailto:john@arbash-meinel.com">john@arbash-meinel.com</a>> wrote: <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 <div><div></div><div class="h5"> Maritza Mendez wrote: > > I have pushed tests based on Vincent's miraculous shell-like tests > facility [1] to lp:~martitzam/bzr/win32-wildcards. > > I have *not* pushed fixes for these bugs yet. Tests first. > > Both tests pass on karmic and fail on win32 as you would expect from the > bug reports. > > I welcome feedback on everything, including especially > > > > [1] I was able to get up and running with just a few hints from > Vincent. It literally took me less than an hour to create two tests, > and this was my first time creating *any* test for bzr. > > </div></div>I should mention: <a href="https://code.launchpad.net/%7Ejameinel/bzr/2.1.0b3-win32-shell-completion/+merge/14445" target="_blank">https://code.launchpad.net/~jameinel/bzr/2.1.0b3-win32-shell-completion/+merge/14445</a> John =:-> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Using GnuPG with Mozilla - <a href="http://enigmail.mozdev.org/" target="_blank">http://enigmail.mozdev.org/</a> iEYEARECAAYFAkryWVIACgkQJdeBCYSNAANbgwCgtUmC9Mk784zb8GTNUUWmjEOS WpUAni/Lq1ghS0MFzH3VzuJ6eRDssrhz =VPtb -----END PGP SIGNATURE----- </blockquote></div> John... I knew that if I offered an ad hoc fix and waited long enough someone would come up with a better way. :) Seriously, I didn't really do that. I am delighted to see a systematic approach. Consider my branch dead, but I would still appreciate any feedback from anyone willing to take a look and offer tips on approach. ~M